From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: [PING][PATCH] binutils-gdb/git: Handle *.ac and *.m4 files in .gitattributes
Date: Wed, 17 Dec 2025 22:25:24 +0100 [thread overview]
Message-ID: <93deb8ec-db69-425a-9a56-30f802363b1b@suse.de> (raw)
In-Reply-To: <20251203085111.3655102-1-tdevries@suse.de>
On 12/3/25 9:51 AM, Tom de Vries wrote:
> Since commit 52ca3d3fe61 ("toplevel: unify the GCC and GDB/binutils .editorconfig
> files"), .editorconfig has settings for .ac and .m4 files:
> ...
> [*.{ac,m4}]
> indent_style = tab
> indent_size = 2
> trim_trailing_whitespace = true
> ...
>
> There are no setting for those files in .gitattributes, so the whitespace
> attribute defaults to trailing-space (shorthand for blank-at-eol,
> blank-at-eof) and space-before-tab.
>
> Since according to .editorconfig the indentation style is tab, add
> indent-with-non-tab as well.
>
> Since aclocal.m4 is generated, unset the whitespace attribute. Likewise for
> configure.
Ping.
Thanks,
- Tom
> ---
> .gitattributes | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/.gitattributes b/.gitattributes
> index 6f7c6d8ba52..3639ebcfe55 100644
> --- a/.gitattributes
> +++ b/.gitattributes
> @@ -33,3 +33,13 @@ ChangeLog merge=merge-changelog
> *.[cChH] whitespace=space-before-tab,indent-with-non-tab,trailing-space
> *.exp whitespace=space-before-tab,indent-with-non-tab,trailing-space
> *.tcl whitespace=space-before-tab,indent-with-non-tab,trailing-space
> +
> +# Autoconf.
> +
> +*.ac whitespace=space-before-tab,indent-with-non-tab,trailing-space
> +*.m4 whitespace=space-before-tab,indent-with-non-tab,trailing-space
> +
> +# Generated files.
> +
> +configure -whitespace
> +aclocal.m4 -whitespace
>
> base-commit: d03293898d81e4273ac7f9163a8186dba46db0e5
next prev parent reply other threads:[~2025-12-17 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 8:51 [PATCH] " Tom de Vries
2025-12-04 16:32 ` Tom Tromey
2025-12-17 21:25 ` Tom de Vries [this message]
2025-12-18 0:18 ` [PING][PATCH] " Alan Modra
2025-12-30 22:54 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93deb8ec-db69-425a-9a56-30f802363b1b@suse.de \
--to=tdevries@suse.de \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox