Re: [PATCH 1/2] gdbsupport: Fix a type of sentinel

[Simon Marchi <simark@simark.ca>]

On 2020-01-28 9:28 a.m., Lukas Durfina wrote:
> ---
>  gdbsupport/ChangeLog | 4 ++++
>  gdbsupport/environ.c | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog
> index 6ea2f2c253..3c77483294 100644
> --- a/gdbsupport/ChangeLog
> +++ b/gdbsupport/ChangeLog
> @@ -1,3 +1,7 @@
> +2020-01-28 Lukas Durfina <ldurfina@tachyum.com>
> +
> +	* environ.c (gdb_environ::set): Fix a type of sentinel.
> +
>  2020-01-24  Christian Biesinger  <cbiesinger@google.com>
>  
>  	* thread-pool.c (set_thread_name): Add an overload for the NetBSD
> diff --git a/gdbsupport/environ.c b/gdbsupport/environ.c
> index 55d0a74c37..32434ee0b7 100644
> --- a/gdbsupport/environ.c
> +++ b/gdbsupport/environ.c
> @@ -105,7 +105,7 @@ gdb_environ::get (const char *var) const
>  void
>  gdb_environ::set (const char *var, const char *value)
>  {
> -  char *fullvar = concat (var, "=", value, NULL);
> +  char *fullvar = concat (var, "=", value, (char *) NULL);
>  
>    /* We have to unset the variable in the vector if it exists.  */
>    unset (var, false);
> -- 
> 2.17.1
> 

Hi Lukas,

Can you please indicate in your commit message the reason why you need this
change?  I presume it fixes some compilation error, in which case please
indicate at least what is the error message and what is the compiler you are
using (name and version).  If you are cross compiling, it can also be good
to mention that as well.

Simon