From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Lukas Durfina <ldurfina@tachyum.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdbsupport: Fix a type of sentinel
Date: Fri, 31 Jan 2020 10:09:00 -0000 [thread overview]
Message-ID: <875zgsym2f.fsf@tromey.com> (raw)
In-Reply-To: <a9ae26e1-fff3-ab2e-cb61-3ac5e3ae8f16@simark.ca> (Simon Marchi's message of "Tue, 28 Jan 2020 11:43:03 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> Can you please indicate in your commit message the reason why you need this
Simon> change? I presume it fixes some compilation error, in which case please
Simon> indicate at least what is the error message and what is the compiler you are
Simon> using (name and version). If you are cross compiling, it can also be good
Simon> to mention that as well.
The bug here is that if NULL is defined as 0, then the sentinel will be
handled incorrectly via varargs if sizeof(void*) > sizeof(int) -- the
value passed in will be narrower than what the callee reads. Jan did a
pass once, ages ago, to fix all of these, but it's easy for new ones to
slip in, since it's not always incorrect.
I like the nullptr idea. Also replacing concat calls with std::string
in appropriate spots seems like a good idea too.
Tom
next prev parent reply other threads:[~2020-01-31 10:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 14:28 Lukas Durfina
2020-01-28 15:05 ` [PATCH 2/2] gdb: " Lukas Durfina
2020-01-28 16:53 ` Simon Marchi
2020-01-28 17:13 ` Aktemur, Tankut Baris
2020-01-30 14:52 ` Lukas Durfina
2020-01-28 16:44 ` [PATCH 1/2] gdbsupport: " Simon Marchi
2020-01-31 10:09 ` Tom Tromey [this message]
2020-01-31 18:37 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zgsym2f.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=ldurfina@tachyum.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox