From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58481 invoked by alias); 31 Jan 2020 10:09:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58473 invoked by uid 89); 31 Jan 2020 10:09:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=slip, narrower X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.50.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Jan 2020 10:09:18 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 77BD1ED60 for ; Fri, 31 Jan 2020 04:09:17 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id xTEii5Qf0kjvMxTEii4NhM; Fri, 31 Jan 2020 04:09:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=itw13uehedeZ6VdD7PY0zPlapZmfzqcmrJG2YzDp748=; b=Nym6xA1eZzIlvz64FsyIUMd9Gw L2akK/Jeb18yP8yRTbAhKPHR5sPezpRPDlA6Y616dm9UoFxcShRI2Yn663qjGSaggAdHlEup7A2XB C2tcjFkMq52JFpwN18MKoBEx5; Received: from [109.236.135.164] (port=43884 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ixTEi-001LEO-29; Fri, 31 Jan 2020 03:09:16 -0700 From: Tom Tromey To: Simon Marchi Cc: Lukas Durfina , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdbsupport: Fix a type of sentinel References: <20200128142830.89282-1-ldurfina@tachyum.com> Date: Fri, 31 Jan 2020 10:09:00 -0000 In-Reply-To: (Simon Marchi's message of "Tue, 28 Jan 2020 11:43:03 -0500") Message-ID: <875zgsym2f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00985.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Can you please indicate in your commit message the reason why you need this Simon> change? I presume it fixes some compilation error, in which case please Simon> indicate at least what is the error message and what is the compiler you are Simon> using (name and version). If you are cross compiling, it can also be good Simon> to mention that as well. The bug here is that if NULL is defined as 0, then the sentinel will be handled incorrectly via varargs if sizeof(void*) > sizeof(int) -- the value passed in will be narrower than what the callee reads. Jan did a pass once, ages ago, to fix all of these, but it's easy for new ones to slip in, since it's not always incorrect. I like the nullptr idea. Also replacing concat calls with std::string in appropriate spots seems like a good idea too. Tom