From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46209 invoked by alias); 28 Jan 2020 16:43:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46196 invoked by uid 89); 28 Jan 2020 16:43:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Jan 2020 16:43:06 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5A4571E5F7; Tue, 28 Jan 2020 11:43:04 -0500 (EST) Subject: Re: [PATCH 1/2] gdbsupport: Fix a type of sentinel To: Lukas Durfina , gdb-patches@sourceware.org References: <20200128142830.89282-1-ldurfina@tachyum.com> From: Simon Marchi Message-ID: Date: Tue, 28 Jan 2020 16:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200128142830.89282-1-ldurfina@tachyum.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00904.txt.bz2 On 2020-01-28 9:28 a.m., Lukas Durfina wrote: > --- > gdbsupport/ChangeLog | 4 ++++ > gdbsupport/environ.c | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog > index 6ea2f2c253..3c77483294 100644 > --- a/gdbsupport/ChangeLog > +++ b/gdbsupport/ChangeLog > @@ -1,3 +1,7 @@ > +2020-01-28 Lukas Durfina > + > + * environ.c (gdb_environ::set): Fix a type of sentinel. > + > 2020-01-24 Christian Biesinger > > * thread-pool.c (set_thread_name): Add an overload for the NetBSD > diff --git a/gdbsupport/environ.c b/gdbsupport/environ.c > index 55d0a74c37..32434ee0b7 100644 > --- a/gdbsupport/environ.c > +++ b/gdbsupport/environ.c > @@ -105,7 +105,7 @@ gdb_environ::get (const char *var) const > void > gdb_environ::set (const char *var, const char *value) > { > - char *fullvar = concat (var, "=", value, NULL); > + char *fullvar = concat (var, "=", value, (char *) NULL); > > /* We have to unset the variable in the vector if it exists. */ > unset (var, false); > -- > 2.17.1 > Hi Lukas, Can you please indicate in your commit message the reason why you need this change? I presume it fixes some compilation error, in which case please indicate at least what is the error message and what is the compiler you are using (name and version). If you are cross compiling, it can also be good to mention that as well. Simon