Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Luis Machado <luis.machado@linaro.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [testsuite] Fix timeout with maint print objfiles
Date: Tue, 27 Apr 2021 13:59:57 -0400	[thread overview]
Message-ID: <a9924c9e-fe6f-f5e3-de88-428608f2874b@polymtl.ca> (raw)
In-Reply-To: <a9a90a15-3ab6-da16-12f3-aa6912f43900@linaro.org>

>>> diff --git a/gdb/psymtab.c b/gdb/psymtab.c
>>> index 75a307c89aa..e3032d60343 100644
>>> --- a/gdb/psymtab.c
>>> +++ b/gdb/psymtab.c
>>> @@ -885,7 +885,7 @@ psymbol_functions::dump (struct objfile *objfile)
>>>         printf_filtered ("%s at ",
>>>                  psymtab->filename);
>>>         gdb_print_host_address (psymtab, gdb_stdout);
>>> -      printf_filtered (", ");
>>> +      printf_filtered ("\n");
>>>         wrap_here ("  ");
>>
>> I think we can remove wrap_here, since we don't rely on wrapping
>> anymore.
>>
> 
> I wasn't sure. The wrap function breaks the line if the string length is greater than the terminal width, no? In this case, if you have a very small terminal, that might influence things.
> 
> It doesn't do anything when running the testsuite though. At least for me, the width is unlimited in this case.

From what I understand, it tells GDB "you could wrap here if what you
print next is going to overshoot the terminal width".  So you use it
between multiple elements printed on the same line.

But doing it just after outputting a \n doesn't make sense.

Simon

  reply	other threads:[~2021-04-27 18:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 14:10 Luis Machado via Gdb-patches
2021-04-27 15:47 ` Simon Marchi via Gdb-patches
2021-04-27 17:51   ` Luis Machado via Gdb-patches
2021-04-27 17:59     ` Simon Marchi via Gdb-patches [this message]
2021-04-27 18:26 ` [PATCH,v2] " Luis Machado via Gdb-patches
2021-04-27 18:45   ` Simon Marchi via Gdb-patches
2021-04-27 23:43     ` Luis Machado via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9924c9e-fe6f-f5e3-de88-428608f2874b@polymtl.ca \
    --to=gdb-patches@sourceware.org \
    --cc=luis.machado@linaro.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox