From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1QZwMydRiGDyDAAAWB0awg (envelope-from ) for ; Tue, 27 Apr 2021 14:00:07 -0400 Received: by simark.ca (Postfix, from userid 112) id C1ED31F11C; Tue, 27 Apr 2021 14:00:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DF5A11E783 for ; Tue, 27 Apr 2021 14:00:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 64D123894C35; Tue, 27 Apr 2021 18:00:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 64D123894C35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619546406; bh=MzHvig4kTPtnYnvVinD9/H/wDulkncBs6dwhPVbgQoE=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=kDStpsh7brBI3IjVcdUEVyk7aj1BWKSFxDKx5wzKqB99XES/tqOxHUYerb22j6R+b JXXokum+w7B724RF5K0DX9+xmn+gdpBmms04Z693rYn4MND1wFO/7P3SnuYPjFOCFM 0QkgEH8M2meMQxL7236dbCfAdJNq5GVP56OH3Nus= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 22C893883035 for ; Tue, 27 Apr 2021 18:00:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 22C893883035 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13RHxwrm005708 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Apr 2021 14:00:02 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13RHxwrm005708 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1A4B71E783; Tue, 27 Apr 2021 13:59:58 -0400 (EDT) Subject: Re: [PATCH] [testsuite] Fix timeout with maint print objfiles To: Luis Machado , gdb-patches@sourceware.org References: <20210427141044.2573352-1-luis.machado@linaro.org> Message-ID: Date: Tue, 27 Apr 2021 13:59:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 27 Apr 2021 17:59:58 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>> diff --git a/gdb/psymtab.c b/gdb/psymtab.c >>> index 75a307c89aa..e3032d60343 100644 >>> --- a/gdb/psymtab.c >>> +++ b/gdb/psymtab.c >>> @@ -885,7 +885,7 @@ psymbol_functions::dump (struct objfile *objfile) >>> printf_filtered ("%s at ", >>> psymtab->filename); >>> gdb_print_host_address (psymtab, gdb_stdout); >>> - printf_filtered (", "); >>> + printf_filtered ("\n"); >>> wrap_here (" "); >> >> I think we can remove wrap_here, since we don't rely on wrapping >> anymore. >> > > I wasn't sure. The wrap function breaks the line if the string length is greater than the terminal width, no? In this case, if you have a very small terminal, that might influence things. > > It doesn't do anything when running the testsuite though. At least for me, the width is unlimited in this case. >From what I understand, it tells GDB "you could wrap here if what you print next is going to overshoot the terminal width". So you use it between multiple elements printed on the same line. But doing it just after outputting a \n doesn't make sense. Simon