Re: [PATCH,v2] [testsuite] Fix timeout with maint print objfiles

[Luis Machado via Gdb-patches <gdb-patches@sourceware.org>]

On 4/27/21 3:45 PM, Simon Marchi wrote:
> 
> 
> On 2021-04-27 2:26 p.m., Luis Machado wrote:
>> Updates on v2:
>>
>> - Add missing exp_continue when looking for "readnow".
>> - Removed wraps
>>
>> --
>>
>> I'm seeing timeouts from gdb.rust/traits.exp when we attempt to print
>> things with "maint print objfiles".
>>
>> This happens for two reasons:
>>
>> 1 - GDB does not explicitly split each entry into its own line, but rather
>>      relies on the terminal's width to insert line breaks.
>>
>> 2 - When running the GDB testsuite, such width may be unlimited, which will
>>      prevent GDB from inserting any line breaks.
>>
>> As a result, the output may be too lengthy and will come in big lines.  Tweak
>> the support library to match the patterns line-by-line, which gives us more
>> time to match things. Also fix GDB's output to print one entry per line,
>> regardless of the terminal width.
>>
>> A similar approach was used in another testcase using the same command (commit
>> eaeaf44cfdc9a4096a0dd52fa0606f29d4bfd48e). With the new line breaks, we don't
>> need a particular pattern, so clean up that test as well.
>>
>> gdb/ChangeLog:
>>
>> YYYY-MM-DD  Luis Machado  <luis.machado@linaro.org>
>>
>> 	* psymtab.c (psymbol_functions::dump): Output newline. Remove wrap.
>> 	* symmisc.c (dump_objfile): Likewise.
>>
>> gdb/testsuite/ChangeLog:
>>
>> YYYY-MM-DD  Luis Machado  <luis.machado@linaro.org>
>>
>> 	* gdb.base/maint.exp: Drop a pattern that is not needed.
>> 	* lib/gdb.exp (readnow): Match line-by-line.
> 
> Thanks, that LGTM.
> 
> Simon
> 

Thanks! Pushed now.