From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8D9oBrGhiGDgEwAAWB0awg (envelope-from ) for ; Tue, 27 Apr 2021 19:43:45 -0400 Received: by simark.ca (Postfix, from userid 112) id 0B2F91F11C; Tue, 27 Apr 2021 19:43:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 52C8C1E783 for ; Tue, 27 Apr 2021 19:43:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 939B4389680F; Tue, 27 Apr 2021 23:43:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 939B4389680F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619567023; bh=7xxiq+j8rTIx83RskPMx91z/akhHVXQBHmxsduslhrE=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=NozdGWQCH8PqrE3IaXa/XLanEy0OgQW4k3qjPaUR1OePk0bcKeLWlQhsPlvOaRSbA I3FQMk3UzJjMptxM4GoQqW+KQU8R44SEg8lszUvambmN506WMDpQz4COd5SCE3aIRQ 9g4alxZ4aaj/jbs27FpTN66GLxa1PpnWpjE1ECwE= Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by sourceware.org (Postfix) with ESMTPS id C07213857011 for ; Tue, 27 Apr 2021 23:43:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C07213857011 Received: by mail-qk1-x732.google.com with SMTP id t17so33416214qkg.4 for ; Tue, 27 Apr 2021 16:43:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7xxiq+j8rTIx83RskPMx91z/akhHVXQBHmxsduslhrE=; b=SrVAJUsvxt4cJkLPrs6yPLqB4w0/VTaNSELnRCz6+3uwaPzxgaOIYOz7bo0mevU69a lPtu2xSASZsIPaPZBeijspFS57KOxwK7rZ2XeK9v4vGgpa6mIf+tQkl5CHggYEEOjOJw PJ+r/JO2b9OJw0bi/nPXloNp4ltVaiby4r3+cwbQk6y1ecWz/6ROeL2m7RPCfkrDbmeJ uOY44hmevv4xzrn1a9QfbKYWNxtPBwt0vs2QhjArLKC+zwjgQi2vbk4m9/YbRgb2Zdi0 QEA3KtTR7ggDLDbfTEjjDJYuKmatram6hJSvMqf9DM+/LS07ETpT4uFX67yEE8i3J3fA Yn6A== X-Gm-Message-State: AOAM5311etLD94x8dBbu9u41yPXycaUbAO+AgmRcHVAH2MJtLOTbnkkL V0FVO6cvbPI0foD0ac+h2WyMvyd+3fapeQ== X-Google-Smtp-Source: ABdhPJxObXI9SxX06FXE9okjYBfrAZrjdWFrlgeJ/8H7SHpbhA2HCw/G0nqL0T7IqaginTWatoWufg== X-Received: by 2002:a37:2708:: with SMTP id n8mr3686331qkn.57.1619567020325; Tue, 27 Apr 2021 16:43:40 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:2d9e:316d:692a:3493:8ea0? ([2804:7f0:4841:2d9e:316d:692a:3493:8ea0]) by smtp.gmail.com with ESMTPSA id d19sm1006177qtd.29.2021.04.27.16.43.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Apr 2021 16:43:39 -0700 (PDT) Subject: Re: [PATCH,v2] [testsuite] Fix timeout with maint print objfiles To: Simon Marchi , gdb-patches@sourceware.org References: <20210427141044.2573352-1-luis.machado@linaro.org> <20210427182608.2596880-1-luis.machado@linaro.org> <9c009fdb-7464-7772-3320-52deaacfd69d@polymtl.ca> Message-ID: <03b17c7c-bba6-87ab-6f3b-7fe938b3a382@linaro.org> Date: Tue, 27 Apr 2021 20:43:34 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <9c009fdb-7464-7772-3320-52deaacfd69d@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 4/27/21 3:45 PM, Simon Marchi wrote: > > > On 2021-04-27 2:26 p.m., Luis Machado wrote: >> Updates on v2: >> >> - Add missing exp_continue when looking for "readnow". >> - Removed wraps >> >> -- >> >> I'm seeing timeouts from gdb.rust/traits.exp when we attempt to print >> things with "maint print objfiles". >> >> This happens for two reasons: >> >> 1 - GDB does not explicitly split each entry into its own line, but rather >> relies on the terminal's width to insert line breaks. >> >> 2 - When running the GDB testsuite, such width may be unlimited, which will >> prevent GDB from inserting any line breaks. >> >> As a result, the output may be too lengthy and will come in big lines. Tweak >> the support library to match the patterns line-by-line, which gives us more >> time to match things. Also fix GDB's output to print one entry per line, >> regardless of the terminal width. >> >> A similar approach was used in another testcase using the same command (commit >> eaeaf44cfdc9a4096a0dd52fa0606f29d4bfd48e). With the new line breaks, we don't >> need a particular pattern, so clean up that test as well. >> >> gdb/ChangeLog: >> >> YYYY-MM-DD Luis Machado >> >> * psymtab.c (psymbol_functions::dump): Output newline. Remove wrap. >> * symmisc.c (dump_objfile): Likewise. >> >> gdb/testsuite/ChangeLog: >> >> YYYY-MM-DD Luis Machado >> >> * gdb.base/maint.exp: Drop a pattern that is not needed. >> * lib/gdb.exp (readnow): Match line-by-line. > > Thanks, that LGTM. > > Simon > Thanks! Pushed now.