From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Move include block to pathstuff.h (no-tn-check)
Date: Tue, 10 Nov 2020 12:14:43 -0500 [thread overview]
Message-ID: <a85a6b43-2ab6-6e4f-62e4-1c7c07640c54@simark.ca> (raw)
In-Reply-To: <20201110165726.789517-1-tromey@adacore.com>
On 2020-11-10 11:57 a.m., Tom Tromey wrote:
> A recent commit caused pathstuff.cc to fail to compile on mingw, like:
>
> ../../binutils-gdb/gdbsupport/pathstuff.cc:324:1: error: no previous declaration for 'std::string find_gdb_home_config_file(const char*, _stati64*)' [-Werror=missing-declarations]
>
> Some newly-added #includes were changing which "stat" was being seen
> by the compiler. This patch moves the includes to the header, so that
> the declaration and definition now agree.
>
> gdbsupport/ChangeLog
> 2020-11-10 Tom Tromey <tromey@adacore.com>
>
> * pathstuff.h: Move include block here...
> * pathstuff.cc: ... from here.
Does this fix this bug?
https://sourceware.org/bugzilla/show_bug.cgi?id=26848
If so, you could add a PR reference and close it. The patch LGTM, since
we reached the same conclusion.
Simon
next prev parent reply other threads:[~2020-11-10 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 16:57 Tom Tromey
2020-11-10 17:14 ` Simon Marchi [this message]
2020-11-10 20:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a85a6b43-2ab6-6e4f-62e4-1c7c07640c54@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox