From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id i7Y5CojKql/6DwAAWB0awg (envelope-from ) for ; Tue, 10 Nov 2020 12:14:48 -0500 Received: by simark.ca (Postfix, from userid 112) id 1D2031F08B; Tue, 10 Nov 2020 12:14:48 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C0F2A1E58F for ; Tue, 10 Nov 2020 12:14:47 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7F3473985402; Tue, 10 Nov 2020 17:14:47 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B02F2386F022 for ; Tue, 10 Nov 2020 17:14:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B02F2386F022 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 155E61E58F; Tue, 10 Nov 2020 12:14:44 -0500 (EST) Subject: Re: [PATCH] Move include block to pathstuff.h (no-tn-check) To: Tom Tromey , gdb-patches@sourceware.org References: <20201110165726.789517-1-tromey@adacore.com> From: Simon Marchi Message-ID: Date: Tue, 10 Nov 2020 12:14:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201110165726.789517-1-tromey@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-11-10 11:57 a.m., Tom Tromey wrote: > A recent commit caused pathstuff.cc to fail to compile on mingw, like: > > ../../binutils-gdb/gdbsupport/pathstuff.cc:324:1: error: no previous declaration for 'std::string find_gdb_home_config_file(const char*, _stati64*)' [-Werror=missing-declarations] > > Some newly-added #includes were changing which "stat" was being seen > by the compiler. This patch moves the includes to the header, so that > the declaration and definition now agree. > > gdbsupport/ChangeLog > 2020-11-10 Tom Tromey > > * pathstuff.h: Move include block here... > * pathstuff.cc: ... from here. Does this fix this bug? https://sourceware.org/bugzilla/show_bug.cgi?id=26848 If so, you could add a PR reference and close it. The patch LGTM, since we reached the same conclusion. Simon