From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH] Move include block to pathstuff.h (no-tn-check)
Date: Tue, 10 Nov 2020 09:57:26 -0700 [thread overview]
Message-ID: <20201110165726.789517-1-tromey@adacore.com> (raw)
A recent commit caused pathstuff.cc to fail to compile on mingw, like:
../../binutils-gdb/gdbsupport/pathstuff.cc:324:1: error: no previous declaration for 'std::string find_gdb_home_config_file(const char*, _stati64*)' [-Werror=missing-declarations]
Some newly-added #includes were changing which "stat" was being seen
by the compiler. This patch moves the includes to the header, so that
the declaration and definition now agree.
gdbsupport/ChangeLog
2020-11-10 Tom Tromey <tromey@adacore.com>
* pathstuff.h: Move include block here...
* pathstuff.cc: ... from here.
---
gdbsupport/ChangeLog | 5 +++++
gdbsupport/pathstuff.cc | 4 ----
gdbsupport/pathstuff.h | 4 ++++
3 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/gdbsupport/pathstuff.cc b/gdbsupport/pathstuff.cc
index a52e53b8671..311456720e4 100644
--- a/gdbsupport/pathstuff.cc
+++ b/gdbsupport/pathstuff.cc
@@ -23,10 +23,6 @@
#include "filenames.h"
#include "gdb_tilde_expand.h"
-#include <sys/types.h>
-#include <sys/stat.h>
-#include <unistd.h>
-
#ifdef USE_WIN32API
#include <windows.h>
#endif
diff --git a/gdbsupport/pathstuff.h b/gdbsupport/pathstuff.h
index 996c8f2bbf6..7e35f62c78c 100644
--- a/gdbsupport/pathstuff.h
+++ b/gdbsupport/pathstuff.h
@@ -22,6 +22,10 @@
#include "gdbsupport/byte-vector.h"
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <unistd.h>
+
/* Path utilities. */
/* Return the real path of FILENAME, expanding all the symbolic links.
--
2.26.2
next reply other threads:[~2020-11-10 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 16:57 Tom Tromey [this message]
2020-11-10 17:14 ` Simon Marchi
2020-11-10 20:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110165726.789517-1-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox