Re: [PATCH 1/7] gdb: implement readnow_functions::find_pc_sect_compunit_symtab

["Jan Vraný" <Jan.Vrany@labware.com>]

On Fri, 2026-02-20 at 07:25 -0700, Tom Tromey wrote:
> > > > > > "Jan" == Jan Vraný <Jan.Vrany@labware.com> writes:
> 
> Jan> Not always. dwarf2_base_index_functions::expand_all_symtabs skips 
> Jan> "partial symtabs", so in some cases not all symtabs are instantiated.
> 
> A partial symtab should be expanded as a side effect of expanding any CU
> that includes it.
> 
> Now, an orphan partial symtab will never be expanded -- but I think
> those are just an error and can be ignored.
> 
> Instead of asserting that the symtab is set, perhaps this should be
> skipping partial units.  

Okay, I'll do that. 

> Though I also wonder why it's referencing the
> DWARF data structures at all and not just working off the compunits.

Other readnow_functions use DWARF structures too so I simply took the same
approach. 

Alternatively, we can base readnow_functions on expanded_symbol_functions and
just override expand_all_symtabs (taking the implementation from dwarf2_base_index_functions).

Thanks!

Jan