From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GKwMAHCEmGkr5AIAWB0awg (envelope-from ) for ; Fri, 20 Feb 2026 10:57:36 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=YdNLpoML; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D9DC11E089; Fri, 20 Feb 2026 10:57:35 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C00E61E089 for ; Fri, 20 Feb 2026 10:57:34 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 31F594B9DB4E for ; Fri, 20 Feb 2026 15:57:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 31F594B9DB4E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=YdNLpoML Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.129.114]) by sourceware.org (Postfix) with ESMTP id A850D4B9DB6D for ; Fri, 20 Feb 2026 15:57:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A850D4B9DB6D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=labware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=labware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A850D4B9DB6D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.114 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771603026; cv=none; b=EPC2tM1eTk6SZlyl4kT493Aredcu1kDGweNUS3tDxUT0yCMK2wnGkfNGTagh3juE/q3CoUbvp6v0F8C0WW4KCQs5zeIGup+C35+snLpD6sTEodd2DvRWRs0OjGTEINNp2LC/Vfnw9/XpA33NFXME7w8n3hJpSbCA9/sqKa7PfNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771603026; c=relaxed/simple; bh=25vU3MjMEgD/k5HQT2lkxkirAbLXHI1e6zSbVjJ8hmI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hmrYjLxvaWm/gzEjGzuPKCmW7Z28GPjt1KK7Ob/aGYKxwjLgyu2sUBXobmUfB6iqufHObDrL8gof0w6e8NKnXa7JKyrL1MLWYTsRkybRVOx0SlqXOVUu0GM6iJsa2FKTIX345RWPofMX61nmTs80lNO4SWZyQAh5YhOhbj4HPE4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A850D4B9DB6D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labware.com; s=mimecast20220511; t=1771603026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=25vU3MjMEgD/k5HQT2lkxkirAbLXHI1e6zSbVjJ8hmI=; b=YdNLpoMLOTTUHpqB3pSReUnw3dz9vvfRa2epNpdLpKCm0g+4Kp2PQ7Fx/F1oswSYHQm/15 28YVZW4c2vhk6l3Kl3EKf9aWr+9gPCeBPbxynV+go652n2rHXVYsENRUGOOkZ013QJLgXI FCVKmmTnhKwWKVPT3Mk8AFwQaidjMvI= Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11021086.outbound.protection.outlook.com [40.93.194.86]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-rDIcTeikOu-p0_k9yDeb9A-2; Fri, 20 Feb 2026 10:57:05 -0500 X-MC-Unique: rDIcTeikOu-p0_k9yDeb9A-2 X-Mimecast-MFC-AGG-ID: rDIcTeikOu-p0_k9yDeb9A_1771603024 Received: from CO1PR17MB5369.namprd17.prod.outlook.com (2603:10b6:303:e8::10) by IA0PR17MB6369.namprd17.prod.outlook.com (2603:10b6:208:435::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.16; Fri, 20 Feb 2026 15:57:02 +0000 Received: from CO1PR17MB5369.namprd17.prod.outlook.com ([fe80::c9b4:108c:cf02:e200]) by CO1PR17MB5369.namprd17.prod.outlook.com ([fe80::c9b4:108c:cf02:e200%5]) with mapi id 15.20.9632.017; Fri, 20 Feb 2026 15:57:02 +0000 From: =?iso-8859-15?Q?Jan_Vran=FD?= To: "tom@tromey.com" CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 1/7] gdb: implement readnow_functions::find_pc_sect_compunit_symtab Thread-Topic: [PATCH 1/7] gdb: implement readnow_functions::find_pc_sect_compunit_symtab Thread-Index: AQHcodGeVjB0dO14AkaTsiJewONJKbWKcXxqgAEV8oCAAB5uIIAAGZYA Date: Fri, 20 Feb 2026 15:57:02 +0000 Message-ID: References: <20260219185638.360694-1-jan.vrany@labware.com> <20260219185638.360694-2-jan.vrany@labware.com> <87ms144i5r.fsf@tromey.com> <6bdb19fc83d8e9c75a32947f1420bfca30a375eb.camel@labware.com> <87342v3320.fsf@tromey.com> In-Reply-To: <87342v3320.fsf@tromey.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR17MB5369:EE_|IA0PR17MB6369:EE_ x-ms-office365-filtering-correlation-id: c7edf690-ee25-4587-490e-08de7098afe6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|1800799024|366016|38070700021 x-microsoft-antispam-message-info: =?iso-8859-15?Q?XZVS4LQBIMKA7CLNrjqRDlg6h+qGmu3S7RIZuE0FwVGBavcNhjpdP2gDo?= =?iso-8859-15?Q?SDBLY0ZrUI/MrrFQDZUXWVkdNJNINa5Wcg0Kej9UPM+0Beu/DQBNjDOJf?= =?iso-8859-15?Q?tcCR3MKGAQMfe8u7a8mT4+8FKIJC35fyjBlXfQC0ircaxcyKuJsx1f2rL?= =?iso-8859-15?Q?LvYyE3AH/aMWA4xhBKkhiROyc+8xTPAm6k/B/+A19gPF8exrAo0+zFmAf?= =?iso-8859-15?Q?I8LBtqmbFpEZLPSZuq+JJ4tEZpv4SP3yFgvQ5lnBMEM382ldilZJt0IxT?= =?iso-8859-15?Q?hzwOjktNnlx4fE38YZD3Dy9AB1giqCb6hdbt4WpaIcjrYlqQ0pY3v5u/W?= =?iso-8859-15?Q?IgU08vh+fSFkS+QLAyXBiOJxjSLFSvrO62Ola596buV8p3VoyFsBmeQZ4?= =?iso-8859-15?Q?I2pkDeY9fyaw1YuUWzDnB4sb/77Tme3eDmdJUysJjFlH+266dhWM4sT1i?= =?iso-8859-15?Q?d4+UzKG5PK8IKWzSwrTLvl8PrEtmwMpfNO2G/WOXR6m+6I/JH+g0ii/ca?= =?iso-8859-15?Q?zPEOluNPtwkc5VqnPo1YqtJn91ITGUQXw3xwwdR0uKiw7P+up9brOCBER?= =?iso-8859-15?Q?LK+XkIaVgGMZs4U9eNVlywljAhUS7k0j7t9RR+9TpPjZksREZqRMrsN4k?= =?iso-8859-15?Q?vq08Jma02KtOkUJmUxP56gGH1AcBxgtuAiicsebTqn5LVkQlqc4cNmK/a?= =?iso-8859-15?Q?39SpHGpR5uzaMGwulu/IeVAERFnSc3CC2G1rN5TgJfWglHgR3L9Drek/1?= =?iso-8859-15?Q?3qIi8+Tx0/sOAzNqlwnzdtvkqHs1D+r2gczIbybiX24Leu8HAoKDDi4K6?= =?iso-8859-15?Q?A8c5jel3WhM1OnLgnP9gqR1U9m+YYk88mArwoTiKWmPUGzvxJkUat6qAm?= =?iso-8859-15?Q?xPMenXL2nIrbw3EWo4pBue1ruRjkmPd+deJHo1VFzVjZ0BwOJqlH0SnHR?= =?iso-8859-15?Q?Ttsl35PR4grRzZnorYUf1yCBhrIv1rOuoYTYAbsRCVOaaXOrcIWArhjBM?= =?iso-8859-15?Q?L+KjZLNVX7uXhaat6Ld2hsP5YyGgm1gzUJdyjEC92nE+LZ/n2VIm5sdNO?= =?iso-8859-15?Q?fgQIcawu/yQgVav1GJalZjMDHq5Qeh62uBcpr51VKVwMv9CKD70s8rKTv?= =?iso-8859-15?Q?sR/aamSFDb/bdLt3k4wXpa7F6pPlobqyWD2N2bjrpbeqh/eHb+p+Exo7I?= =?iso-8859-15?Q?fH/fSjG0/maXdW/gp46OZNtxIuvWJ58Y3XJ/tMbdRLWsVuxcj36xiPku8?= =?iso-8859-15?Q?UoyV48r1qO05Fl1ixi1GqJg+olJjM6W+Lb7MXUhAd6KMhw03GOSQ/sVW5?= =?iso-8859-15?Q?Ao39PZqIHzklNcxEaU2ey5204ioW9ATu4K9bxBrBpKpivTnvM6ETDpoWN?= =?iso-8859-15?Q?CVZiVGEqH1TtHhyEFEMkEEVXmoYhjVNkl9hnzwJBX4jP6/0Zy83lpNoQm?= =?iso-8859-15?Q?gMVQ7YmMr7AFRE/bnbudjZ+/hu9yiGwj3AUTCMDZRu3Ec149rReeN/RJv?= =?iso-8859-15?Q?Tyws70fPYwugwyb4LUI0/FC3+JnclrCdDZ4SdWnXdsjieyf+4MHhm0Stg?= =?iso-8859-15?Q?KUOzYcCDMa82tSbrWIIstwlbsxxpKzaTQi96Fkog4BaLA3+u8HNef0Mqw?= =?iso-8859-15?Q?EVr+2U5yK3EKvVF7TRq/UHiRlEhRXPvEGMhYEyZREXXkESC/CdaCS5CfG?= =?iso-8859-15?Q?62GmohkckvpoQ3DNbVEjQF2rBOv+4+nuzbV0/boVQtV3mxs=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR17MB5369.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700021); DIR:OUT; SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-15?Q?ee7iyr+D/mXEfdg+RdPepN+qY5v9JERZleE2hENhEE8ryscmKvtnJt13L?= =?iso-8859-15?Q?ZBYDgZ8duYR7ZWTiKMtkDz1uq1VZGyPXUif+41McbMAX1EmZCQuR4moog?= =?iso-8859-15?Q?LC6WyTpKCAbsfSMzuBDGIc1cwanONCJWVxdw4WRQunK1yDHhgxLcVQhYK?= =?iso-8859-15?Q?KhzPBZjUNsMjlKJUsEjpVfJdExeVZQxn+O/Xn/iTqBEyJ01FhMoxlVgyh?= =?iso-8859-15?Q?1SFumXi4O9hI1D7LJGND+kquSMmiED9T/eWgoyOW0Gj1/gfqNwJJlsXXI?= =?iso-8859-15?Q?lzB0ISojq6WADdHyPoGAgb9b0uRihm8OOAyb7trXqtzNd9wXQssaJGR0d?= =?iso-8859-15?Q?4ADnVsuftqFpLo3zJAUysCPLdXowryQczknBALFq0tEDobC0KNdVbxISp?= =?iso-8859-15?Q?to1Zw0bCBOFMo9PcLkQq1OQFr1CJcQ0zBLr4r+QFAXH7L6tVg9qskM628?= =?iso-8859-15?Q?12VPmgyiZ5Vs8SPq8m/VLmC7n+eCFqCwcB68bjeBoTfEr/cJkwlp6Te4u?= =?iso-8859-15?Q?S7zc3Hifr1G+Ucqrhx1kfaLaeKWNhquKrcPYej4iZ38ovYU6EbTLbTFoT?= =?iso-8859-15?Q?reMgo/4T31mi7Du8Zdvo3GazYByrywz2P2cZLIHBmTgpxfOCbKMOFp6Xc?= =?iso-8859-15?Q?E915k0RDuBQmppsHeNi+0j+5bjZH5OFUDNWk8GWS/ndDvAbf5+q8usB0f?= =?iso-8859-15?Q?2XjfmrgtDX6+m4i3aCSAqilzXGq2FBU8KhjtocuqJZzIUNR79ZObmAmek?= =?iso-8859-15?Q?uB7EkPzQnaJ763OftmyxYjFapNCOcbdUDTodznyI7ImOdY+kQq1axbd7G?= =?iso-8859-15?Q?BDWL1fMldf7fID4QG9SzLyJeEmjhe1H7gEiP/LqiepDqEGuCPZYbTjyfV?= =?iso-8859-15?Q?PgftkfRQUNIaBek5S7sS53eOmEm/1aLDHUYZtHxbAEzi9sq9SqePxgVb9?= =?iso-8859-15?Q?dc5l7qUPZnu3GOj8ZCKyyG+P1t3FxpJwCBQT7I2xgPuehTYCwyiP7lo6d?= =?iso-8859-15?Q?Z94O69+1MCSvMdxZKwz9ZfQqyDP0/giu7i+vmzrjIYAI/uy9hl9JjYiPn?= =?iso-8859-15?Q?R0HErBLOutJfvLI4PKO3qhAw8FLjcU6vNiU4fuN82JQetDqSSZKm31rMc?= =?iso-8859-15?Q?4DL3Z9Z/DRHXxo37zF7ivCpV/a5+jeLBe+aR6RfQLJ2j/GNNtXmJxx5vd?= =?iso-8859-15?Q?hK3f5q0p+zqKWAYOt36OdjJuRxjwhGSNN8crwLspF9hotuKzYFEih2wJ7?= =?iso-8859-15?Q?IP3iwNZj1itHyHR1fusbTBSJQPRd61ZCegsjAzrhpeBE/YN5b4pNNs/LA?= =?iso-8859-15?Q?5VrnvtZmDhptvfn/lu0HrCixfICq2X17dHqU2+fddq2TVjFmgBXGBqnWg?= =?iso-8859-15?Q?6ls82HxhUJhUMqQurkDwNiUu1IGtYNvZ9ycXMnlaCkObFG8R4wMPoUqgE?= =?iso-8859-15?Q?5B5ZhkCgfzi2J3N+t6SDO8iPaWlJAIlDtewj7JrAL8PMG+OFpS9Tl2Ts6?= =?iso-8859-15?Q?93Fn3jX/aG1JmdFprT1jSYTW9ud5OwERCxG5virs6R0UWFt5fpX7/iQPh?= =?iso-8859-15?Q?/xDobrsaASvuY5IO6qFyYd6zX20ge+zwLIMzJ3fqM30R0YS3yxI5Mviv/?= =?iso-8859-15?Q?R83tBSY/r+JTNwg8tu4pOzLnvaRIqQlp1Z9sAIWbSQ+eLwFp6b2ifmQTg?= =?iso-8859-15?Q?LKcpitMfQQaXVLRKFkGVagvXc8mZsDbahsKFhejotvmB9t1H1yDhW3XtU?= =?iso-8859-15?Q?zwcgovvS8OSEPaL139ahBSM0OBMgogQvMz2G+zUssKBp26XGygN4I85Is?= =?iso-8859-15?Q?+0gxgnNW5yRZgntRl53kXL6ZyWzwom4Qm+XxlbXw=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR17MB5369.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7edf690-ee25-4587-490e-08de7098afe6 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2026 15:57:02.1520 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: C7jD8wd75jEMaaMFoyaZ7rVWy3AzPE+7CO+OIGn0WE9w+Wd08oOomxXk942gq7s5p7dyBSDmfL2iggML3+MTqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR17MB6369 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xvD66mvxEE12UQHhyjSK2S0s0UCD7iDWDRY3y59dD7I_1771603024 X-Mimecast-Originator: labware.com Content-Language: en-US Content-Type: text/plain; charset=ISO-8859-15 Content-ID: Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Fri, 2026-02-20 at 07:25 -0700, Tom Tromey wrote: > > > > > > "Jan" =3D=3D Jan Vran=FD writes: >=20 > Jan> Not always. dwarf2_base_index_functions::expand_all_symtabs skips=20 > Jan> "partial symtabs", so in some cases not all symtabs are instantiated= . >=20 > A partial symtab should be expanded as a side effect of expanding any CU > that includes it. >=20 > Now, an orphan partial symtab will never be expanded -- but I think > those are just an error and can be ignored. >=20 > Instead of asserting that the symtab is set, perhaps this should be > skipping partial units.=A0=A0 Okay, I'll do that.=20 > Though I also wonder why it's referencing the > DWARF data structures at all and not just working off the compunits. Other readnow_functions use DWARF structures too so I simply took the same approach.=20 Alternatively, we can base readnow_functions on expanded_symbol_functions a= nd just override expand_all_symtabs (taking the implementation from dwarf2_bas= e_index_functions). Thanks! Jan=20