From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: Ulrich Weigand <uweigand@de.ibm.com>, lgustavo@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3] [ppc64] Add POWER8/ISA 2.07 atomic sequences single-stepping support
Date: Tue, 21 Feb 2017 14:46:00 -0000 [thread overview]
Message-ID: <a30b3ce0-e301-26a8-23b1-fda5f4952936@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170221105525.933CED8313F@oc3748833570.ibm.com>
On 02/21/2017 07:55 AM, Ulrich Weigand wrote:
> Luis Machado wrote:
>> On 02/16/2017 05:42 PM, Edjunior Barbosa Machado wrote:
>>> What about gdb.arch/ppc64-isa207-atomic-inst.*?
>>>
>>
>> Could be. I don't have a better suggestion. Maybe Ulrich has.
>
> Not really ... the name looks good to me.
>
>>> +if {![istarget "powerpc*"] || ![is_lp64_target]} {
>>> + verbose "Skipping testing of powerpc64 single stepping over atomic sequences."
>>
>> untested "skipping powerpc isa 207 atomic sequences test"?
>
> Agreed, makes sense.
>
>> Otherwise i have no further comments.
>
> Thanks for the review, Luis!
>
> Edjunior, the patch is OK with the above change.
>
> Thanks,
> Ulrich
>
Thank you folks for the review! Just checked in with the change Luis suggested:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2039d74e780db6659c87cd3c426d526615cfe703
--
Edjunior
next prev parent reply other threads:[~2017-02-21 14:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 3:03 [PATCH] [ppc64] Add POWER8 " Edjunior Barbosa Machado
2017-02-06 10:03 ` Luis Machado
2017-02-06 12:55 ` Peter Bergner
2017-02-14 0:48 ` [PATCH v2] " Edjunior Barbosa Machado
2017-02-15 10:00 ` Luis Machado
2017-02-15 12:01 ` Edjunior Barbosa Machado
2017-02-15 12:13 ` Luis Machado
2017-02-16 23:42 ` [PATCH v3] [ppc64] Add POWER8/ISA 2.07 " Edjunior Barbosa Machado
2017-02-20 19:52 ` Luis Machado
2017-02-21 10:55 ` Ulrich Weigand
2017-02-21 14:46 ` Edjunior Barbosa Machado [this message]
2017-02-14 3:36 ` [PATCH] [trivial] Fix test names starting with uppercase in gdb.arch/ppc64-atomic-inst.exp Edjunior Barbosa Machado
2017-02-15 9:30 ` Luis Machado
2017-02-15 12:59 ` Ulrich Weigand
2017-02-21 14:44 ` Edjunior Barbosa Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a30b3ce0-e301-26a8-23b1-fda5f4952936@linux.vnet.ibm.com \
--to=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox