Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: Luis Machado <lgustavo@codesourcery.com>, gdb-patches@sourceware.org
Cc: uweigand@de.ibm.com
Subject: [PATCH] [trivial] Fix test names starting with uppercase in gdb.arch/ppc64-atomic-inst.exp
Date: Tue, 14 Feb 2017 03:36:00 -0000	[thread overview]
Message-ID: <1d9ca4d1-7101-e16d-4f78-93991f3d4d15@linux.vnet.ibm.com> (raw)
In-Reply-To: <38fe05a1-770c-e9f1-ecc0-042dfe0a470e@codesourcery.com>

On 02/06/2017 08:03 AM, Luis Machado wrote:
>> @@ -52,6 +54,18 @@ proc do_test { displaced } {
>>      gdb_breakpoint "$bp2" "Breakpoint $decimal at $hex" \
>>      "Set the breakpoint at the start of the ldarx/stdcx sequence"
>>
>> +    set bp3 [gdb_get_line_number "lbarx"]
>> +    gdb_breakpoint "$bp3" "Breakpoint $decimal at $hex" \
>> +    "Set the breakpoint at the start of the lbarx/stbcx sequence"
> 
> I think my previous set of testsuite fixups failed to catch these test
> names starting with uppercase. But we're requiring test names to start
> with lowercase now. I can address the rest of the offenders in a future
> patch, but new code should have the right format.
> 

Hi,
this trivial patch fixes the test names starting with uppercase using gdb_test
in gdb.arch/ppc64-atomic-inst.exp.

Thanks,
--
Edjunior

gdb/testsuite/
2017-02-14  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>

	* gdb.arch/ppc64-atomic-inst.exp: Fix test names starting with
	uppercase.

---
 gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp b/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp
index d1b3a7d..7bfff6c 100644
--- a/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp
+++ b/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp
@@ -46,23 +46,23 @@ proc do_test { displaced } {
 
     set bp1 [gdb_get_line_number "lwarx"]
     gdb_breakpoint "$bp1" "Breakpoint $decimal at $hex" \
-	"Set the breakpoint at the start of the lwarx/stwcx sequence"
+	"set the breakpoint at the start of the lwarx/stwcx sequence"
 
     set bp2 [gdb_get_line_number "ldarx"]
     gdb_breakpoint "$bp2" "Breakpoint $decimal at $hex" \
-	"Set the breakpoint at the start of the ldarx/stdcx sequence"
+	"set the breakpoint at the start of the ldarx/stdcx sequence"
 
     gdb_test continue "Continuing.*Breakpoint $decimal.*" \
-	"Continue until lwarx/stwcx start breakpoint"
+	"continue until lwarx/stwcx start breakpoint"
 
     gdb_test nexti "bne.*1b" \
-	"Step through the lwarx/stwcx sequence"
+	"step through the lwarx/stwcx sequence"
 
     gdb_test continue "Continuing.*Breakpoint $decimal.*" \
-	"Continue until ldarx/stdcx start breakpoint"
+	"continue until ldarx/stdcx start breakpoint"
 
     gdb_test nexti "bne.*1b" \
-	"Step through the ldarx/stdcx sequence"
+	"step through the ldarx/stdcx sequence"
 }
 
 foreach displaced { "off" "on" } {
-- 
1.8.3.1


  parent reply	other threads:[~2017-02-14  3:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06  3:03 [PATCH] [ppc64] Add POWER8 atomic sequences single-stepping support Edjunior Barbosa Machado
2017-02-06 10:03 ` Luis Machado
2017-02-06 12:55   ` Peter Bergner
2017-02-14  0:48   ` [PATCH v2] " Edjunior Barbosa Machado
2017-02-15 10:00     ` Luis Machado
2017-02-15 12:01       ` Edjunior Barbosa Machado
2017-02-15 12:13         ` Luis Machado
2017-02-16 23:42           ` [PATCH v3] [ppc64] Add POWER8/ISA 2.07 " Edjunior Barbosa Machado
2017-02-20 19:52             ` Luis Machado
2017-02-21 10:55               ` Ulrich Weigand
2017-02-21 14:46                 ` Edjunior Barbosa Machado
2017-02-14  3:36   ` Edjunior Barbosa Machado [this message]
2017-02-15  9:30     ` [PATCH] [trivial] Fix test names starting with uppercase in gdb.arch/ppc64-atomic-inst.exp Luis Machado
2017-02-15 12:59       ` Ulrich Weigand
2017-02-21 14:44         ` Edjunior Barbosa Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d9ca4d1-7101-e16d-4f78-93991f3d4d15@linux.vnet.ibm.com \
    --to=emachado@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox