From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90359 invoked by alias); 21 Feb 2017 14:46:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90342 invoked by uid 89); 21 Feb 2017 14:46:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=HTo:U*uweigand X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Feb 2017 14:46:31 +0000 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v1LEdbPO143470 for ; Tue, 21 Feb 2017 09:46:30 -0500 Received: from e24smtp02.br.ibm.com (e24smtp02.br.ibm.com [32.104.18.86]) by mx0a-001b2d01.pphosted.com with ESMTP id 28rnr8wgqq-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 21 Feb 2017 09:46:29 -0500 Received: from localhost by e24smtp02.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Feb 2017 11:46:27 -0300 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp02.br.ibm.com (10.172.0.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 21 Feb 2017 11:46:26 -0300 Received: from d24relay04.br.ibm.com (d24relay04.br.ibm.com [9.18.232.146]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 885FB352005F for ; Tue, 21 Feb 2017 09:45:52 -0500 (EST) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay04.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v1LEkPqQ30277662 for ; Tue, 21 Feb 2017 11:46:26 -0300 Received: from d24av04.br.ibm.com (localhost [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v1LEkPlV012865 for ; Tue, 21 Feb 2017 11:46:25 -0300 Received: from [9.85.136.99] ([9.85.136.99]) by d24av04.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id v1LEkMIs012809; Tue, 21 Feb 2017 11:46:24 -0300 Subject: Re: [PATCH v3] [ppc64] Add POWER8/ISA 2.07 atomic sequences single-stepping support To: Ulrich Weigand , lgustavo@codesourcery.com References: <20170221105525.933CED8313F@oc3748833570.ibm.com> Cc: gdb-patches@sourceware.org From: Edjunior Barbosa Machado Date: Tue, 21 Feb 2017 14:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170221105525.933CED8313F@oc3748833570.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17022114-0020-0000-0000-0000028998FF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17022114-0021-0000-0000-000030A4A4F0 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-21_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702210141 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00567.txt.bz2 On 02/21/2017 07:55 AM, Ulrich Weigand wrote: > Luis Machado wrote: >> On 02/16/2017 05:42 PM, Edjunior Barbosa Machado wrote: >>> What about gdb.arch/ppc64-isa207-atomic-inst.*? >>> >> >> Could be. I don't have a better suggestion. Maybe Ulrich has. > > Not really ... the name looks good to me. > >>> +if {![istarget "powerpc*"] || ![is_lp64_target]} { >>> + verbose "Skipping testing of powerpc64 single stepping over atomic sequences." >> >> untested "skipping powerpc isa 207 atomic sequences test"? > > Agreed, makes sense. > >> Otherwise i have no further comments. > > Thanks for the review, Luis! > > Edjunior, the patch is OK with the above change. > > Thanks, > Ulrich > Thank you folks for the review! Just checked in with the change Luis suggested: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2039d74e780db6659c87cd3c426d526615cfe703 -- Edjunior