Re: [PATCH 0/3] Change some functions to methods of program_space

[Simon Marchi <simark@simark.ca>]

On 2026-02-13 16:09, Tom Tromey wrote:
> This changes a few functions to become methods of program_space.
> It also moves them to progspace.[ch], where they belong.
> 
> Regression tested on x86-64 Fedora 40.
> 
> Signed-off-by: Tom Tromey <tom@tromey.com>
> ---
> Tom Tromey (3):
>       Move entry point functions to program_space
>       Use std::optional in entry_point_address_query
>       Change have_*_symbols functions to methods of program_space
> 
>  gdb/ada-exp.y        |  4 ++--
>  gdb/arc-tdep.c       |  2 +-
>  gdb/arch-utils.c     |  2 +-
>  gdb/c-exp.y          |  4 ++--
>  gdb/cli/cli-cmds.c   |  4 ++--
>  gdb/d-exp.y          |  4 ++--
>  gdb/frame.c          |  8 +++----
>  gdb/go-exp.y         |  4 ++--
>  gdb/infcall.c        |  2 +-
>  gdb/linespec.c       | 10 ++++----
>  gdb/objfiles.c       | 65 ----------------------------------------------------
>  gdb/objfiles.h       | 22 ------------------
>  gdb/p-exp.y          |  4 ++--
>  gdb/parse.c          |  4 ++--
>  gdb/progspace.c      | 62 +++++++++++++++++++++++++++++++++++++++++++++++++
>  gdb/progspace.h      | 20 ++++++++++++++++
>  gdb/solib-frv.c      |  9 ++++----
>  gdb/source.c         |  4 ++--
>  gdb/symfile.c        |  8 +++----
>  gdb/symtab.c         |  8 +++----
>  gdb/tui/tui-disasm.c |  4 ++--
>  21 files changed, 125 insertions(+), 129 deletions(-)
> ---
> base-commit: 51b7445c65ff06a6d9740fc635be73287527a0a5
> change-id: 20260213-random-methods-2f946240d78d
> 
> Best regards,

I sent a comment about the naming on patch 3, but otherwise it all LGTM.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon