From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qS4FC4v3j2kMLToAWB0awg (envelope-from ) for ; Fri, 13 Feb 2026 23:18:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1771042699; bh=xiTQ34934M77M5iUKwatTZOHjI/WJgHp4GlMEfqFv2k=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nW6xlvOyDRABqwrU48xTuPrTooeb5vg7DIwLtQmGk8xmbsvVpQvYtCmghEy3Esqtl 8zEL2agguqtoIAurCnvJs4QegKnGeLy5jYiUIN7uA5cxQHjii1KIamCYXqDY+pI+GI Agg96oTanLvLwcN71yk1zkMaZ+wDfkbrqoXPtbhc= Received: by simark.ca (Postfix, from userid 112) id 28DB91E0BA; Fri, 13 Feb 2026 23:18:19 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=OA50Rbq1; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A39461E089 for ; Fri, 13 Feb 2026 23:18:18 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 1114F4BAE7CD for ; Sat, 14 Feb 2026 04:18:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1114F4BAE7CD Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=OA50Rbq1 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id CC53F4BAD173 for ; Sat, 14 Feb 2026 04:17:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC53F4BAD173 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CC53F4BAD173 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771042642; cv=none; b=eVLnSIRnS4XfY9rfzNUeL6sI3B/5kOIdccl+/7DP+WFa15nRftJds74BJWR+zTFFulhiWuIrZgw/MxT2dzbxLcqy1ka6psjDEag0Re8OLR/1ETA8vPhGmy5TCHllzSK5TzJY6ndN00hqvaWxgeFY4ibCidJR0I3irSclHQpi798= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771042642; c=relaxed/simple; bh=xiTQ34934M77M5iUKwatTZOHjI/WJgHp4GlMEfqFv2k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LWX7IW5gHyB8div2FEBk2DUOZJFweX4SCow0cGlaybpQzs3z/C+825v+SZhovR3Fr5Uh5FpNmNknKu6jKsEC0OhzB1uO8JNOUVMJgtkYdY1dVjfmoE4O2qVZj34VPp+6DK649E2oVtEFxE4mNBdXuRvfctuCf3Nf14+brOQ/d/Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CC53F4BAD173 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1771042642; bh=xiTQ34934M77M5iUKwatTZOHjI/WJgHp4GlMEfqFv2k=; h=Date:Subject:To:References:From:In-Reply-To:From; b=OA50Rbq1uqGusYQhGb5XztYcEigLkbMm+Tlr3zvSbIdRS7VJ/cxkRDrUp2ph3SWHR CYYsmaluoRLNK50QZgTulo+gls/gkVUr+e9WOGADdo5G+OdGz9dSPJrBQQjmJhHwwk jwii6h1H6F1EVzj50bbZh70wCnKRMM5737RjBTsQ= Received: by simark.ca (Postfix) id 2D00B1E089; Fri, 13 Feb 2026 23:17:22 -0500 (EST) Message-ID: Date: Fri, 13 Feb 2026 23:17:21 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Change some functions to methods of program_space To: Tom Tromey , gdb-patches@sourceware.org References: <20260213-random-methods-v1-0-59bdac57c3e1@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260213-random-methods-v1-0-59bdac57c3e1@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-02-13 16:09, Tom Tromey wrote: > This changes a few functions to become methods of program_space. > It also moves them to progspace.[ch], where they belong. > > Regression tested on x86-64 Fedora 40. > > Signed-off-by: Tom Tromey > --- > Tom Tromey (3): > Move entry point functions to program_space > Use std::optional in entry_point_address_query > Change have_*_symbols functions to methods of program_space > > gdb/ada-exp.y | 4 ++-- > gdb/arc-tdep.c | 2 +- > gdb/arch-utils.c | 2 +- > gdb/c-exp.y | 4 ++-- > gdb/cli/cli-cmds.c | 4 ++-- > gdb/d-exp.y | 4 ++-- > gdb/frame.c | 8 +++---- > gdb/go-exp.y | 4 ++-- > gdb/infcall.c | 2 +- > gdb/linespec.c | 10 ++++---- > gdb/objfiles.c | 65 ---------------------------------------------------- > gdb/objfiles.h | 22 ------------------ > gdb/p-exp.y | 4 ++-- > gdb/parse.c | 4 ++-- > gdb/progspace.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++++ > gdb/progspace.h | 20 ++++++++++++++++ > gdb/solib-frv.c | 9 ++++---- > gdb/source.c | 4 ++-- > gdb/symfile.c | 8 +++---- > gdb/symtab.c | 8 +++---- > gdb/tui/tui-disasm.c | 4 ++-- > 21 files changed, 125 insertions(+), 129 deletions(-) > --- > base-commit: 51b7445c65ff06a6d9740fc635be73287527a0a5 > change-id: 20260213-random-methods-2f946240d78d > > Best regards, I sent a comment about the naming on patch 3, but otherwise it all LGTM. Approved-By: Simon Marchi Simon