Re: [PATCH 3/3] Change have_*_symbols functions to methods of program_space

[Simon Marchi <simark@simark.ca>]

>  /* Prints the list of program spaces and their details on UIOUT.  If
>     REQUESTED is not -1, it's the ID of the pspace that should be
>     printed.  Otherwise, all spaces are printed.  */
> diff --git a/gdb/progspace.h b/gdb/progspace.h
> index 3ed33b2e472..b3d8d6d39ed 100644
> --- a/gdb/progspace.h
> +++ b/gdb/progspace.h
> @@ -340,6 +340,18 @@ struct program_space
>       it is not known.  */
>    CORE_ADDR entry_point_address () const;
>  
> +  /* Return true if any objfile of this program space has partial
> +     symbols.  */
> +  bool have_partial_symbols ();
> +
> +  /* Return true if any objfile of this program space has full
> +     symbols.  */
> +  bool have_full_symbols ();
> +
> +  /* Return true if any objfile of this program space has minimal
> +     symbols.  */
> +  bool have_minimal_symbols ();

Maybe just a naming nit, I would s/have_/has_/ in the names.  I feel
like it would read and sound better:

  pspace->have_partial_symbols ()

vs

  pspace->has_partial_symbols ()

Assuming that the pspace is the entity that "has" the symbols.

Simon