From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aVSjAnr3j2kMLToAWB0awg (envelope-from ) for ; Fri, 13 Feb 2026 23:18:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1771042681; bh=FGL56RsYMryhQpGRw7Hhl56Ugb2CkKJMQwcx6atrVNA=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=atc2ie0OfoEL2am0enH+L3n0Eq+8yWNhOZ3oTBCU6F/9/vZLF9PD+TiZeLTtr1r5l LS4ky04ib/46j3MqTX9T3MkMfm5G5xO1PBHtraCfyXt26R9n57AoAt3HHbK5tFsLZZ jCwkaR/GWWC/1EBdUiuaBEYverebhXCBIagFgYDs= Received: by simark.ca (Postfix, from userid 112) id E1A951E0BA; Fri, 13 Feb 2026 23:18:01 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=gzl++bc+; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0D5701E089 for ; Fri, 13 Feb 2026 23:18:01 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 52D884BAD178 for ; Sat, 14 Feb 2026 04:18:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 52D884BAD178 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=gzl++bc+ Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 230AD4BAD14A for ; Sat, 14 Feb 2026 04:16:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 230AD4BAD14A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 230AD4BAD14A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771042618; cv=none; b=d5x+/Yj3FYysTuQVK2n9Zg8p+b5ur9MQ+HIF797tQ3SXIlzE/PxaBFSJQnNSMwMSfF6zkhEEw47QBmlN8+hNFgI+iWBQ0nVnbe9pRSADam40DHBDvBM7V/8Y/U94lc2JIUcSgzmz8aWUzOTQmtFIBn8388JDFV73hwvU1mEsdEg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771042618; c=relaxed/simple; bh=FGL56RsYMryhQpGRw7Hhl56Ugb2CkKJMQwcx6atrVNA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=xh4xcfRa2/6z3Jnxy4mjXWduBZ1Yqh7fkD9AsAzewjwb11Qk9jMOHCk0huBj0JH8QbQfA6o8KNybNfY7ZkMna6slwVuD9tiK6vJp6S7W49cG5Wg9NT48MDuVzrqmPDKsfVQDbibSQ+zuq+h9OLvjt107EptQcCAVuA/UfFyvHJI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 230AD4BAD14A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1771042617; bh=FGL56RsYMryhQpGRw7Hhl56Ugb2CkKJMQwcx6atrVNA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=gzl++bc+dO3jkshhPCCmneQvmFLlZohT48TWJK/8hDdarcnOt8aIdK9eKuRaDurIB JifAifechMC1b4pXte2/OnThuAHfaKjK+g/IpdUf7M9tlNQpG3mNXwthNw5VsleY4B CAMq1VBtvmcIy6nB3CrMp/3DpcXZUgYLWqHwDWCc= Received: by simark.ca (Postfix) id 555C11E089; Fri, 13 Feb 2026 23:16:57 -0500 (EST) Message-ID: <1d54a20a-fe14-4c67-92a4-20a3333cd84d@simark.ca> Date: Fri, 13 Feb 2026 23:16:56 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] Change have_*_symbols functions to methods of program_space To: Tom Tromey , gdb-patches@sourceware.org References: <20260213-random-methods-v1-0-59bdac57c3e1@tromey.com> <20260213-random-methods-v1-3-59bdac57c3e1@tromey.com> From: Simon Marchi Content-Language: en-US In-Reply-To: <20260213-random-methods-v1-3-59bdac57c3e1@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > /* Prints the list of program spaces and their details on UIOUT. If > REQUESTED is not -1, it's the ID of the pspace that should be > printed. Otherwise, all spaces are printed. */ > diff --git a/gdb/progspace.h b/gdb/progspace.h > index 3ed33b2e472..b3d8d6d39ed 100644 > --- a/gdb/progspace.h > +++ b/gdb/progspace.h > @@ -340,6 +340,18 @@ struct program_space > it is not known. */ > CORE_ADDR entry_point_address () const; > > + /* Return true if any objfile of this program space has partial > + symbols. */ > + bool have_partial_symbols (); > + > + /* Return true if any objfile of this program space has full > + symbols. */ > + bool have_full_symbols (); > + > + /* Return true if any objfile of this program space has minimal > + symbols. */ > + bool have_minimal_symbols (); Maybe just a naming nit, I would s/have_/has_/ in the names. I feel like it would read and sound better: pspace->have_partial_symbols () vs pspace->has_partial_symbols () Assuming that the pspace is the entity that "has" the symbols. Simon