Re: [PATCH 1/2] Add support for setting disassembler-options in GDB for POWER, ARM and S390

[Pedro Alves <palves@redhat.com>]

On 11/18/2016 04:56 PM, Peter Bergner wrote:

> diff --git a/gdb/NEWS b/gdb/NEWS
> index a597405..54a6b7b 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -36,6 +36,16 @@
>  
>  Synopsys ARC                   arc*-*-elf32
>  
> +* New commands
> +
> +set disassembler-options
> +show disassembler-options
> +  Controls the passing of target specific information to the disassembler.
> +  If it is necessary to specify more than one disassembler option then
> +  multiple options can be placed together into a comma separated list.
> +  Default is ''.  Currently the only supported targets are ARM, PowerPC
> +  and S/390.
> +

This will need a change to the GDB manual as well.  It'd probably 
be a good idea to refer to the -M/--disassembler-options section
of the binutils/disassembler manual for the architecture specific
options.

It'll be good to include an arch-independent gdb test to make sure
that "set disassembler-options" on other architectures doesn't
crash and cover some corner cases.  E.g., test at least both:

 "set disassembler-options"
 "set disassembler-options non-existing-option"

Thanks,
Pedro Alves