From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89975 invoked by alias); 18 Nov 2016 17:23:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89897 invoked by uid 89); 18 Nov 2016 17:23:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Nov 2016 17:23:17 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B89757F7D4; Fri, 18 Nov 2016 17:23:16 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAIHN51M013298; Fri, 18 Nov 2016 12:23:05 -0500 Subject: Re: [PATCH 1/2] Add support for setting disassembler-options in GDB for POWER, ARM and S390 To: Peter Bergner , Eli Zaretskii References: <83eg28dcjk.fsf@gnu.org> <019eaf5d-9ace-539e-8501-feb3cb0eed6c@vnet.ibm.com> Cc: nickc@redhat.com, gdb-patches@sourceware.org, uweigand@de.ibm.com, amodra@gmail.com, binutils@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 18 Nov 2016 17:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <019eaf5d-9ace-539e-8501-feb3cb0eed6c@vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00516.txt.bz2 On 11/18/2016 04:56 PM, Peter Bergner wrote: > diff --git a/gdb/NEWS b/gdb/NEWS > index a597405..54a6b7b 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -36,6 +36,16 @@ > > Synopsys ARC arc*-*-elf32 > > +* New commands > + > +set disassembler-options > +show disassembler-options > + Controls the passing of target specific information to the disassembler. > + If it is necessary to specify more than one disassembler option then > + multiple options can be placed together into a comma separated list. > + Default is ''. Currently the only supported targets are ARM, PowerPC > + and S/390. > + This will need a change to the GDB manual as well. It'd probably be a good idea to refer to the -M/--disassembler-options section of the binutils/disassembler manual for the architecture specific options. It'll be good to include an arch-independent gdb test to make sure that "set disassembler-options" on other architectures doesn't crash and cover some corner cases. E.g., test at least both: "set disassembler-options" "set disassembler-options non-existing-option" Thanks, Pedro Alves