Re: [PATCH 1/2] Add support for setting disassembler-options in GDB for POWER, ARM and S390

[Pedro Alves <palves@redhat.com>]

On 11/22/2016 05:04 PM, Peter Bergner wrote:
> On 11/18/16 11:23 AM, Pedro Alves wrote:
>> On 11/18/2016 04:56 PM, Peter Bergner wrote:
>> This will need a change to the GDB manual as well.  It'd probably
>> be a good idea to refer to the -M/--disassembler-options section
>> of the binutils/disassembler manual for the architecture specific
>> options.
> 
> I don't know the manual at all.  Can you point me to the spot
> you'd like the documentation inserted at?

Between the documentation of "disassemble" and "set disassembly-flavor",
perhaps?

> 
> 
>> It'll be good to include an arch-independent gdb test to make sure
>> that "set disassembler-options" on other architectures doesn't
>> crash and cover some corner cases.  E.g., test at least both:
>>
>>  "set disassembler-options"
>>  "set disassembler-options non-existing-option"
> 
> Is there an example of an arch independent gdb test case I can
> use as a skeleton?

Most tests are arch independent.  Ones that aren't will
have some istarget check.  Tests in gdb.arch/ are examples.
See "Testsuite Organization" in testsuite/README.

See also <https://sourceware.org/gdb/wiki/GDBTestcaseCookbook>,
though for the suggestion above, you don't even need to compile a
program and run to main.  The suggestion would basically be
translated to something like:

 gdb_exit
 gdb_start

 # Using gdb_test_no_output assuming these (should) produce no output.
 gdb_test_no_output "set disassembler-options"
 gdb_test_no_output "show disassembler-options"

 gdb_test "set disassembler-options non-existing-option" "whatever gdb says"

Thanks,
Pedro Alves