From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tim Wiederhake <tim.wiederhake@intel.com>
Cc: gdb-patches@sourceware.org, palves@redhat.com,
markus.t.metzger@intel.com
Subject: Re: [PATCH 6/7] python: Add tests for record Python bindings
Date: Thu, 27 Oct 2016 15:59:00 -0000 [thread overview]
Message-ID: <a14406cc50e97665c450bf04219f85be@polymtl.ca> (raw)
In-Reply-To: <1477549711-2603-7-git-send-email-tim.wiederhake@intel.com>
On 2016-10-27 02:28, Tim Wiederhake wrote:
> +# Skip this test if btrace is disabled.
> +
> +if { [skip_btrace_tests] } { return -1 }
Would it be helpful to have at least some minimal tests using the "full"
method, even if btrace is not available?
> +with_test_prefix "no or double record" {
> + gdb_test "python print(gdb.current_recording())" "None"
> +
> + gdb_test_no_output "python gdb.start_recording()"
> + gdb_test "python gdb.start_recording(\"full\")" ".*gdb\.error:
> The process is already being recorded\..*"
> +
> + gdb_test_no_output "python gdb.stop_recording()"
> + gdb_test "python gdb.stop_recording()" ".*gdb\.error: No record
> target is currently active\..*"
These last two tests give the same test name (which must be unique).
You could give a specific name to one of them.
next prev parent reply other threads:[~2016-10-27 15:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 6:29 [PATCH 0/7] Python bindings for btrace recordings Tim Wiederhake
2016-10-27 6:29 ` [PATCH 2/7] btrace: Export btrace_decode_error function Tim Wiederhake
2016-10-27 6:29 ` [PATCH 4/7] python: Create Python bindings for record history Tim Wiederhake
2016-10-27 15:53 ` Simon Marchi
2016-10-28 14:12 ` Wiederhake, Tim
2016-10-27 6:29 ` [PATCH 5/7] python: Implement btrace " Tim Wiederhake
2016-10-27 6:29 ` [PATCH 7/7] Add documentation for new instruction record Python bindings Tim Wiederhake
2016-10-27 15:02 ` Eli Zaretskii
2016-10-27 16:10 ` Simon Marchi
2016-10-27 6:29 ` [PATCH 3/7] btrace: Use binary search to find instruction Tim Wiederhake
2016-10-27 14:28 ` Simon Marchi
2016-11-02 10:01 ` Wiederhake, Tim
2016-11-02 11:24 ` Simon Marchi
2016-10-27 6:29 ` [PATCH 6/7] python: Add tests for record Python bindings Tim Wiederhake
2016-10-27 15:59 ` Simon Marchi [this message]
2016-10-28 13:49 ` Wiederhake, Tim
2016-10-28 17:47 ` Simon Marchi
2016-10-27 6:29 ` [PATCH 1/7] btrace: Count gaps as one instruction explicitly Tim Wiederhake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a14406cc50e97665c450bf04219f85be@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=palves@redhat.com \
--cc=tim.wiederhake@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox