From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50797 invoked by alias); 27 Oct 2016 15:59:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50785 invoked by uid 89); 27 Oct 2016 15:59:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Oct 2016 15:59:52 +0000 Received: by simark.ca (Postfix, from userid 33) id DD0AF1E935; Thu, 27 Oct 2016 11:59:50 -0400 (EDT) To: Tim Wiederhake Subject: Re: [PATCH 6/7] python: Add tests for record Python bindings X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 27 Oct 2016 15:59:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org, palves@redhat.com, markus.t.metzger@intel.com In-Reply-To: <1477549711-2603-7-git-send-email-tim.wiederhake@intel.com> References: <1477549711-2603-1-git-send-email-tim.wiederhake@intel.com> <1477549711-2603-7-git-send-email-tim.wiederhake@intel.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.2 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00770.txt.bz2 On 2016-10-27 02:28, Tim Wiederhake wrote: > +# Skip this test if btrace is disabled. > + > +if { [skip_btrace_tests] } { return -1 } Would it be helpful to have at least some minimal tests using the "full" method, even if btrace is not available? > +with_test_prefix "no or double record" { > + gdb_test "python print(gdb.current_recording())" "None" > + > + gdb_test_no_output "python gdb.start_recording()" > + gdb_test "python gdb.start_recording(\"full\")" ".*gdb\.error: > The process is already being recorded\..*" > + > + gdb_test_no_output "python gdb.stop_recording()" > + gdb_test "python gdb.stop_recording()" ".*gdb\.error: No record > target is currently active\..*" These last two tests give the same test name (which must be unique). You could give a specific name to one of them.