From: "Wiederhake, Tim" <tim.wiederhake@intel.com>
To: 'Simon Marchi' <simon.marchi@polymtl.ca>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"palves@redhat.com" <palves@redhat.com>,
"Metzger, Markus T" <markus.t.metzger@intel.com>
Subject: RE: [PATCH 3/7] btrace: Use binary search to find instruction.
Date: Wed, 02 Nov 2016 10:01:00 -0000 [thread overview]
Message-ID: <9676A094AF46E14E8265E7A3F4CCE9AF90CE3F@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <32eeec01cc2ddc61dcb90caab5a6e645@polymtl.ca>
Hi Simon,
Thanks for your input!
> Unless you expect to backport this patch in the 7.12 branch (which I don't think is the case here), you can use C++ standard containers and functions. Specifically, std::vector instead of DEF_VEC, and probably std::lower_bound (if I understand correctly what the code is doing).
struct btrace_thread_info is initialized by memset'ing it to zero. If I'm not mistaken we can't do that if the struct contains a C++ member with a constructor.
> Also, since we now have btrace_function pointers in a sorted vector, do we still need them to be linked together as a linked list?
The btrace_function pointers will go away in the next patch series.
Tim
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2016-11-02 10:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 6:29 [PATCH 0/7] Python bindings for btrace recordings Tim Wiederhake
2016-10-27 6:29 ` [PATCH 1/7] btrace: Count gaps as one instruction explicitly Tim Wiederhake
2016-10-27 6:29 ` [PATCH 6/7] python: Add tests for record Python bindings Tim Wiederhake
2016-10-27 15:59 ` Simon Marchi
2016-10-28 13:49 ` Wiederhake, Tim
2016-10-28 17:47 ` Simon Marchi
2016-10-27 6:29 ` [PATCH 3/7] btrace: Use binary search to find instruction Tim Wiederhake
2016-10-27 14:28 ` Simon Marchi
2016-11-02 10:01 ` Wiederhake, Tim [this message]
2016-11-02 11:24 ` Simon Marchi
2016-10-27 6:29 ` [PATCH 7/7] Add documentation for new instruction record Python bindings Tim Wiederhake
2016-10-27 15:02 ` Eli Zaretskii
2016-10-27 16:10 ` Simon Marchi
2016-10-27 6:29 ` [PATCH 5/7] python: Implement btrace Python bindings for record history Tim Wiederhake
2016-10-27 6:29 ` [PATCH 2/7] btrace: Export btrace_decode_error function Tim Wiederhake
2016-10-27 6:29 ` [PATCH 4/7] python: Create Python bindings for record history Tim Wiederhake
2016-10-27 15:53 ` Simon Marchi
2016-10-28 14:12 ` Wiederhake, Tim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9676A094AF46E14E8265E7A3F4CCE9AF90CE3F@irsmsx105.ger.corp.intel.com \
--to=tim.wiederhake@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=palves@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox