From: Mike Frysinger <vapier@gentoo.org>
To: Mark Wielaard <mark@klomp.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: Fix -Wincompatible-pointer-types in frv/sem.c
Date: Mon, 22 Jan 2024 08:15:57 -0500 [thread overview]
Message-ID: <Za5qjRqGyBW4Cmmn@vapier> (raw)
In-Reply-To: <07b7c6829601ac5742ed2c12715c3490a4ad0fbb.camel@klomp.org>
[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
On 22 Jan 2024 12:30, Mark Wielaard wrote:
> On Sun, 2024-01-21 at 22:45 -0500, Mike Frysinger wrote:
> > On 22 Jan 2024 00:06, Mark Wielaard wrote:
> > > The issue is that sim_queue_fn_di_write takes a function with a DI argument
> > > but frvbf_h_acc40U_set takes a UDI. Since there is no sim_queue_fn that
> > > takes a UDI just define frvbf_h_acc40U_set as if it takes a DI.
> > > ---
> > > sim/frv/cpu.c | 2 +-
> > > sim/frv/cpu.h | 2 +-
> >
> > unfortunately this doesn't work as cpu.[ch] is generated.
> >
> > https://sourceware.org/pipermail/gdb-patches/2023-December/205492.html
> > https://sourceware.org/PR29752
>
> O, that is unfortunate. I admit to not know how to actually regenerate
> these files.
`make frv/cgen` would do it for frv
> Also it seems PR29752 does include a solution. What kind
> of testing would you like to see to make sure it is correct?
i don't understand frv internals/whatever well enough to know if my proposal
is reasonable. although if we don't get a response, i guess there isn't much
choice as things fail to build with newer compilers.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-01-22 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 23:06 Mark Wielaard
2024-01-22 3:45 ` Mike Frysinger
2024-01-22 11:30 ` Mark Wielaard
2024-01-22 13:15 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za5qjRqGyBW4Cmmn@vapier \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox