From: Mike Frysinger <vapier@gentoo.org>
To: Mark Wielaard <mark@klomp.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: Fix -Wincompatible-pointer-types in frv/sem.c
Date: Sun, 21 Jan 2024 22:45:03 -0500 [thread overview]
Message-ID: <Za3kv5Y2BAxS0sFq@vapier> (raw)
In-Reply-To: <20240121230620.575972-1-mark@klomp.org>
[-- Attachment #1: Type: text/plain, Size: 1949 bytes --]
On 22 Jan 2024 00:06, Mark Wielaard wrote:
> GCC errors on -Wincompatible-pointer-types
>
> sim/frv/sem.c: In function ‘frvbf_sem_mmachu’:
> sim/frv/sem.c:24345:41: error: passing argument 2 of ‘sim_queue_fn_di_write’ from incompatible pointer type [-Wincompatible-pointer-types]
> 24345 | sim_queue_fn_di_write (current_cpu, frvbf_h_acc40U_set, FLD (f_ACC40Uk), opval);
> | ^~~~~~~~~~~~~~~~~~
> | |
> | void (*)(SIM_CPU *, UINT, UDI) {aka void (*)(struct _sim_cpu *, unsigned int, long unsigned int)}
> In file included from ../../binutils-gdb/sim/common/cgen-cpu.h:25,
> from ../../binutils-gdb/sim/common/sim-cpu.h:32,
> from ../../binutils-gdb/sim/common/sim-base.h:90,
> from ../../binutils-gdb/sim/frv/sim-main.h:41,
> from ../../binutils-gdb/sim/frv/sem.c:28:
> ../../binutils-gdb/sim/common/cgen-par.h:195:47: note: expected ‘void (*)(SIM_CPU *, UINT, DI)’ {aka ‘void (*)(struct _sim_cpu *, unsigned int, long int)’} but argument is of type ‘void (*)(SIM_CPU *, UINT, UDI)’ {aka ‘void (*)(struct _sim_cpu *, unsigned int, long unsigned int)’}
> 195 | extern void sim_queue_fn_di_write (SIM_CPU *, void (*)(SIM_CPU *, UINT, DI), UINT, DI);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> The issue is that sim_queue_fn_di_write takes a function with a DI argument
> but frvbf_h_acc40U_set takes a UDI. Since there is no sim_queue_fn that
> takes a UDI just define frvbf_h_acc40U_set as if it takes a DI.
> ---
> sim/frv/cpu.c | 2 +-
> sim/frv/cpu.h | 2 +-
unfortunately this doesn't work as cpu.[ch] is generated.
https://sourceware.org/pipermail/gdb-patches/2023-December/205492.html
https://sourceware.org/PR29752
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-01-22 3:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 23:06 Mark Wielaard
2024-01-22 3:45 ` Mike Frysinger [this message]
2024-01-22 11:30 ` Mark Wielaard
2024-01-22 13:15 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za3kv5Y2BAxS0sFq@vapier \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox