From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dGh2KqZqrmVlFAQAWB0awg (envelope-from ) for ; Mon, 22 Jan 2024 08:16:22 -0500 Received: by simark.ca (Postfix, from userid 112) id A25B41E0C3; Mon, 22 Jan 2024 08:16:22 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9080E1E092 for ; Mon, 22 Jan 2024 08:16:20 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 438EB3858436 for ; Mon, 22 Jan 2024 13:16:20 +0000 (GMT) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 264593858D3C for ; Mon, 22 Jan 2024 13:15:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 264593858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 264593858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705929359; cv=none; b=fCd7PSfuFcwI6DoAtp9Ad6LwrYIQdsVRhMFnwWuW3MV7X15iSbhMUOOR1CDjSPjsWBYSnRklRvtkaqbC+asxQuZFauZ7xnUlfwc6uyT2nWH5R63rhW/V621hJbbkvqEMPbyreTNoGefBRrAERoi8XqKG344SboAU6gruR2f7Bc0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705929359; c=relaxed/simple; bh=7liwZGE68OxKnJW6MZVUy9uMvSo+cWOPDKTTbHE0fWw=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=IWH26RFtQVqn2L7BtzosjhuqqF4V8RxKN2KUbfzkhzIZcGiHatR7sq41Kv2h3wjCuV916DmKO1jOSlBDBU4lSmBhx2LVTDjp9PJHXcV9F+BE889b+5/1wzbw+8oDs+01KILqnEA5hOzPSPl5Dotu7FRJdjC9a/d8POKow4gsSaQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 9D121343264; Mon, 22 Jan 2024 13:15:57 +0000 (UTC) Date: Mon, 22 Jan 2024 08:15:57 -0500 From: Mike Frysinger To: Mark Wielaard Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: Fix -Wincompatible-pointer-types in frv/sem.c Message-ID: References: <20240121230620.575972-1-mark@klomp.org> <07b7c6829601ac5742ed2c12715c3490a4ad0fbb.camel@klomp.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cl4Sz3TXtNcmo7zo" Content-Disposition: inline In-Reply-To: <07b7c6829601ac5742ed2c12715c3490a4ad0fbb.camel@klomp.org> X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org --cl4Sz3TXtNcmo7zo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 22 Jan 2024 12:30, Mark Wielaard wrote: > On Sun, 2024-01-21 at 22:45 -0500, Mike Frysinger wrote: > > On 22 Jan 2024 00:06, Mark Wielaard wrote: > > > The issue is that sim_queue_fn_di_write takes a function with a DI ar= gument > > > but frvbf_h_acc40U_set takes a UDI. Since there is no sim_queue_fn th= at > > > takes a UDI just define frvbf_h_acc40U_set as if it takes a DI. > > > --- > > > sim/frv/cpu.c | 2 +- > > > sim/frv/cpu.h | 2 +- > >=20 > > unfortunately this doesn't work as cpu.[ch] is generated. > >=20 > > https://sourceware.org/pipermail/gdb-patches/2023-December/205492.html > > https://sourceware.org/PR29752 >=20 > O, that is unfortunate. I admit to not know how to actually regenerate > these files. `make frv/cgen` would do it for frv > Also it seems PR29752 does include a solution. What kind > of testing would you like to see to make sure it is correct? i don't understand frv internals/whatever well enough to know if my proposal is reasonable. although if we don't get a response, i guess there isn't mu= ch choice as things fail to build with newer compilers. -mike --cl4Sz3TXtNcmo7zo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmWuao0ACgkQQWM7n+g3 9YHaxRAA3TAXEv4S6Kq7CuuvD6h77M33DjrEBLpAYk68sc197Bl9vYnKEiqv9SCs RySOP3RO5OdGn7akyX2qtBqAeBrhoYPuzx9GnVtMdQ2rf7D8Ct0nMNQfa8Gtru/1 64DLVKq2qTDTvTttUCReaCG4XpzQ36xVl14paNsK9TAGH9GQ1ljobvTtbDyos0UR knoQt1IOfyHhOyPgngYCuO/CtCpMBg8sWiPdABJZn6Lobu712xQZLA3wX9/JFLUS yDS1QyRoZ3L/LylVOw+GoSIuFUAu59tWQnMhUMoSfkIKpBH8bKodV8K7e95MGbTf sxgR2fx4vMozPdzNFVAwg3IGnWJgg043gRkmBybjpMgFxbZaXEfPkDNi211DNr28 aVtqPwCNJwFxNgxRMoZVgrMYMsYxqm4OBxyRJaYVd6yYXAMpBa7OXq7vdEtN1Er3 vvqQlTGEVuYm1RSDhywv6OGnT0YaW92lirLpfXocOSu0+LaPSHtMDU4LMXbFtSzH CU5E+Y9KK8cFIEZ02kJxIOo+1BV5nu1+LuHKFoFtKkrqO0dPqvbvfiJMX2XcacRB VTPOqUvR4InNzvGZCHFul494u7Frz1WXJ6rglvjwzzuk3axTODOOG8x13kkG09lZ PKQ/gXQtknIhB3OwDz/FOrGg5bIn6C887hsCoTwpcKVKUukkLXI= =/ZlX -----END PGP SIGNATURE----- --cl4Sz3TXtNcmo7zo--