From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Orgad Shaneh <orgads@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim/erc32: fix signedness compatiblity and redefinition warnings
Date: Wed, 27 Oct 2021 05:37:28 -0400 [thread overview]
Message-ID: <YXkd2Dtyaa6aNsuD@vapier> (raw)
In-Reply-To: <20211027062717.3056451-1-orgads@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
On 27 Oct 2021 06:27, Orgad Shaneh via Gdb-patches wrote:
> --- a/sim/erc32/func.c
> +++ b/sim/erc32/func.c
>
> +void boot_init (void);
this should be in sis.h instead so it's shared between users & definition
> unsigned char i[4];
>
> - sis_memory_read(addr, i, 4);
> + sis_memory_read(addr, (char *)i, 4);
we should change sis_memory_read to take a void* buffer instead. then we never
have to worry about or fight signed warnings like this again.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-10-27 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 6:27 Orgad Shaneh via Gdb-patches
2021-10-27 9:37 ` Mike Frysinger via Gdb-patches [this message]
2021-10-28 7:55 ` Orgad Shaneh via Gdb-patches
2021-10-29 5:31 ` Mike Frysinger via Gdb-patches
2021-10-29 6:42 Orgad Shaneh via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXkd2Dtyaa6aNsuD@vapier \
--to=gdb-patches@sourceware.org \
--cc=orgads@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox