From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id b9d1Nx4eeWFMDAAAWB0awg (envelope-from ) for ; Wed, 27 Oct 2021 05:38:38 -0400 Received: by simark.ca (Postfix, from userid 112) id D074E1EE18; Wed, 27 Oct 2021 05:38:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2BCB21E813 for ; Wed, 27 Oct 2021 05:38:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AE1753857C6D for ; Wed, 27 Oct 2021 09:38:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE1753857C6D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1635327517; bh=Yc+q5hSoI5JL1BaW9khQwQiA1GVEhVGVe4s+GOOzml0=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ohlkJSpEN2KQknwNJJbjE9v7c1mGySz8X4g9oTsdzlIutTTzv6EJLoYYE2Ezb4gQk 8d7lGNYJLuzcpzU7yC16xKKqlSgBoGSeefaPbZrJINo/gIGbjLFPHFaZEm9t29s/gQ 8n77hlOAJwUEOFnsFEvZWi4+epctTmMGd0hKOn+A= Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 87DE03858401 for ; Wed, 27 Oct 2021 09:37:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 87DE03858401 Received: by smtp.gentoo.org (Postfix, from userid 559) id 0746D343940; Wed, 27 Oct 2021 09:37:28 +0000 (UTC) Date: Wed, 27 Oct 2021 05:37:28 -0400 To: Orgad Shaneh Subject: Re: [PATCH] sim/erc32: fix signedness compatiblity and redefinition warnings Message-ID: Mail-Followup-To: Orgad Shaneh , gdb-patches@sourceware.org References: <20211027062717.3056451-1-orgads@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xSNF/ssmvZh6wuiZ" Content-Disposition: inline In-Reply-To: <20211027062717.3056451-1-orgads@gmail.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --xSNF/ssmvZh6wuiZ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 27 Oct 2021 06:27, Orgad Shaneh via Gdb-patches wrote: > --- a/sim/erc32/func.c > +++ b/sim/erc32/func.c > > +void boot_init (void); this should be in sis.h instead so it's shared between users & definition > unsigned char i[4]; > =20 > - sis_memory_read(addr, i, 4); > + sis_memory_read(addr, (char *)i, 4); we should change sis_memory_read to take a void* buffer instead. then we n= ever have to worry about or fight signed warnings like this again. -mike --xSNF/ssmvZh6wuiZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmF5HdgACgkQQWM7n+g3 9YEX6Q/+KfG/TJEd6AXldntgDTJHkk7yccSctNx6p6ai9SSwVATKFFokc67dmSM+ +rzOLjLlpLjjATsWGnll5/aEIpZkyKTQrJPgJbKjVmtjwORt3Dwt2V2Eo8Eet3oQ nyNb8rKxORKca3lAX3ifZe3K2NcHnQTGACk71oiFv6oQI9VyJfhlaX+Ez2EB8iNI 3ljhXVXe9wofw/N94UynoUAy+ZTkq259YUvrh3yS1T7neaB1vHnKRPGSnOuZYp7V Bo54RqrXhHMbFJ9jkQEER73QPqjz8Yi+/4l12vrjrbroWS4r9tE1hipLR6GDjdTn WOzzNEkFmwraKTqEvrG5aNBLnt7XSdZxnidQLzmTB96Gkqw/5jeGNYE6ouS0TL23 J0Thho+8EL9VcsaEpK/swYQ3vpObKPVis2rHh24A6tx8lX7hlJZsMQKlTZQAuQJ9 +uIYQb/TOCFKMoqmbJTe+gpSO1EYQMKbn1ZOJUK7Rz0qgO3Sql/vvsgqxObjNFeE Bj8cNdzx1tKx2K6KSL8Fs1Q1zSEm/7KJ6OWzVN0Zan5bsMWgRu9Me23+praOi3NN v81RMgFpOICOic41GvtLNKrc1AKSEB4AStrp3zT5GTYB6ok1JQ9yatF4SaMQqWO6 pHaryQhRwBYFijMwC8sclf6DZNF/Rq7qkXZyhla7LOzb8RgZ+88= =6irW -----END PGP SIGNATURE----- --xSNF/ssmvZh6wuiZ--