On 27 Oct 2021 06:27, Orgad Shaneh via Gdb-patches wrote:
> --- a/sim/erc32/func.c
> +++ b/sim/erc32/func.c
>
> +void boot_init (void);

this should be in sis.h instead so it's shared between users & definition

>      unsigned char           i[4];
>  
> -    sis_memory_read(addr, i, 4);
> +    sis_memory_read(addr, (char *)i, 4);

we should change sis_memory_read to take a void* buffer instead.  then we never
have to worry about or fight signed warnings like this again.
-mike