From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/2] sim: h8300 Fixed different behavior in preinc/predec.
Date: Tue, 25 May 2021 19:09:59 -0400 [thread overview]
Message-ID: <YK2DvjWJFDWoojBw@vapier> (raw)
In-Reply-To: <20210525141016.91316-1-ysato@users.sourceforge.jp>
On 25 May 2021 23:10, Yoshinori Sato wrote:
just nits. looks fine otherwise, although i'm no h8300 expert.
> + case OP_PREINC:
> + if (OP_KIND(dst->opcode) == O_MOV)
space before the (
> + case X (OP_REG_DEC, SB): /* Register direct, affected decrement byte. */
> + *val = GET_B_REG (rn) - 1;
> + break;
> + case X (OP_REG_DEC, SW): /* Register direct, affected decrement word. */
> + *val = GET_W_REG (rn) - 2;
> + break;
> + case X (OP_REG_DEC, SL): /* Register direct, affected decrement long. */
> + *val = GET_L_REG (rn) - 4;
> + break;
> + case X (OP_REG_INC, SB): /* Register direct, affected increment byte. */
> + *val = GET_B_REG (rn) + 1;
> + break;
> + case X (OP_REG_INC, SW): /* Register direct, affected increment word. */
> + *val = GET_W_REG (rn) + 2;
> + break;
> + case X (OP_REG_INC, SL): /* Register direct, affected increment long. */
> + *val = GET_L_REG (rn) + 4;
> + break;
2 spaces after those . in the comment
-mike
next prev parent reply other threads:[~2021-05-25 23:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 14:16 [PATCH " Yoshinori Sato
2021-05-21 14:16 ` [PATCH 2/2] sim: h8300 add special case test Yoshinori Sato
2021-05-21 15:03 ` [PATCH RESEND " Yoshinori Sato
2021-05-21 22:41 ` Mike Frysinger via Gdb-patches
2021-05-21 22:41 ` [PATCH 1/2] sim: h8300 Fixed different behavior in preinc/predec Mike Frysinger via Gdb-patches
2021-05-23 13:42 ` Yoshinori Sato
2021-05-25 14:10 ` [PATCH v2 " Yoshinori Sato
2021-05-25 14:10 ` [PATCH v2 2/2] sim: h8300 add special case test Yoshinori Sato
2021-05-25 23:10 ` Mike Frysinger via Gdb-patches
2021-05-25 23:09 ` Mike Frysinger via Gdb-patches [this message]
2021-05-26 11:52 ` [PATCH v3 1/2] sim: h8300 Fixed different behavior in preinc/predec Yoshinori Sato
2021-05-26 11:52 ` [PATCH v3 2/2] sim: h8300 add special case test Yoshinori Sato
2021-05-26 20:23 ` [PATCH v3 1/2] sim: h8300 Fixed different behavior in preinc/predec Mike Frysinger via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK2DvjWJFDWoojBw@vapier \
--to=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox