From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KGDIGM6DrWABDAAAWB0awg (envelope-from ) for ; Tue, 25 May 2021 19:10:06 -0400 Received: by simark.ca (Postfix, from userid 112) id 638391F11C; Tue, 25 May 2021 19:10:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CE7501E813 for ; Tue, 25 May 2021 19:10:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32BE93857802; Tue, 25 May 2021 23:10:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32BE93857802 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1621984205; bh=5VOAgXgWPcFcddjam41tbJuISkma1zSxpCKBkKUIsfU=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lg7hXDc/CslOB9N+n+oRvtjLLkbvWJz3AMSAiZt+Ha+S0FTvf+FASCCEX4iHg8j6h 7b7rFpT46btvb7GGwbqlE192LqaZNA4Eu1Q1nQLdcuWgEgbS+6KZhbaeoK3ZK4jajL TnhlSmhb75S9Fo0IafBoku2IefKZiwTgkpSTHwZc= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id DFEE4385803D for ; Tue, 25 May 2021 23:10:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DFEE4385803D Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id C5F3F340E06; Tue, 25 May 2021 23:10:00 +0000 (UTC) Date: Tue, 25 May 2021 19:09:59 -0400 To: Yoshinori Sato Subject: Re: [PATCH v2 1/2] sim: h8300 Fixed different behavior in preinc/predec. Message-ID: Mail-Followup-To: Yoshinori Sato , gdb-patches@sourceware.org References: <20210521141655.68398-1-ysato@users.sourceforge.jp> <20210525141016.91316-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210525141016.91316-1-ysato@users.sourceforge.jp> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 25 May 2021 23:10, Yoshinori Sato wrote: just nits. looks fine otherwise, although i'm no h8300 expert. > + case OP_PREINC: > + if (OP_KIND(dst->opcode) == O_MOV) space before the ( > + case X (OP_REG_DEC, SB): /* Register direct, affected decrement byte. */ > + *val = GET_B_REG (rn) - 1; > + break; > + case X (OP_REG_DEC, SW): /* Register direct, affected decrement word. */ > + *val = GET_W_REG (rn) - 2; > + break; > + case X (OP_REG_DEC, SL): /* Register direct, affected decrement long. */ > + *val = GET_L_REG (rn) - 4; > + break; > + case X (OP_REG_INC, SB): /* Register direct, affected increment byte. */ > + *val = GET_B_REG (rn) + 1; > + break; > + case X (OP_REG_INC, SW): /* Register direct, affected increment word. */ > + *val = GET_W_REG (rn) + 2; > + break; > + case X (OP_REG_INC, SL): /* Register direct, affected increment long. */ > + *val = GET_L_REG (rn) + 4; > + break; 2 spaces after those . in the comment -mike