From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Faraz Shahbazker <fshahbazker@wavecomp.com>
Cc: Chao-ying Fu <cfu@wavecomp.com>,
gdb-patches@sourceware.org,
"Maciej W . Rozycki" <macro@orcam.me.uk>
Subject: Re: [PATCH 2/2] [pr gdb/19447] sim: mips: Add shadow mappings for 32-bit memory address space
Date: Wed, 12 May 2021 14:21:57 -0400 [thread overview]
Message-ID: <YJwcxTmMa8pcXVwp@vapier> (raw)
In-Reply-To: <20210504232117.896136-2-fshahbazker@wavecomp.com>
On 05 May 2021 04:51, Faraz Shahbazker wrote:
> --- a/sim/mips/interp.c
> +++ b/sim/mips/interp.c
> @@ -438,6 +438,9 @@ sim_open (SIM_OPEN_KIND kind, host_callback *cb,
> /* memory alias K1BASE@1,K1SIZE%MEMSIZE,K0BASE */
> sim_do_commandf (sd, "memory alias 0x%lx@1,0x%lx%%0x%lx,0x%0x",
> K1BASE, K1SIZE, (long)mem_size, K0BASE);
> + if (WITH_TARGET_WORD_BITSIZE == 64)
> + sim_do_commandf (sd, "memory alias 0x%lx,0x%lx,0x%lx",
> + (K0BASE), (long)mem_size, EXTENDED(K0BASE));
instead of using %lx & casting to (long), use sim's PRIx* for the format.
sim_do_commandf (sd, "memory alias 0x%x,0x%" PRIxTA ",0x%" PRIxTW,
K0BASE, mem_size, EXTENDED(K0BASE));
-mike
next prev parent reply other threads:[~2021-05-12 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 23:21 [PATCH 1/2] [pr gdb/19447] sim: mips: Only truncate sign extension bits for 32-bit target models Faraz Shahbazker
2021-05-04 23:21 ` [PATCH 2/2] [pr gdb/19447] sim: mips: Add shadow mappings for 32-bit memory address space Faraz Shahbazker
2021-05-12 18:21 ` Mike Frysinger via Gdb-patches [this message]
2021-05-17 7:37 ` Faraz Shahbazker
2021-05-17 7:45 ` [PATCH v2 1/2] [pr gdb/19447] sim: mips: Only truncate sign extension bits for 32-bit target models Faraz Shahbazker
2021-05-17 7:45 ` [PATCH v2 2/2] [pr gdb/19447] sim: mips: Add shadow mappings for 32-bit memory address space Faraz Shahbazker
2021-05-22 0:50 ` Mike Frysinger via Gdb-patches
2021-05-22 0:49 ` [PATCH v2 1/2] [pr gdb/19447] sim: mips: Only truncate sign extension bits for 32-bit target models Mike Frysinger via Gdb-patches
2021-05-11 21:56 ` [PATCH " Mike Frysinger via Gdb-patches
2021-05-12 16:36 ` [EXTERNAL]Re: " Faraz Shahbazker
2021-05-12 18:17 ` Mike Frysinger via Gdb-patches
2021-05-05 12:18 Faraz Shahbazker
2021-05-05 12:18 ` [PATCH 2/2] [pr gdb/19447] sim: mips: Add shadow mappings for 32-bit memory address space Faraz Shahbazker
2021-05-05 15:47 [PATCH 1/2] [pr gdb/19447] sim: mips: Only truncate sign extension bits for 32-bit target models Faraz Shahbazker
2021-05-05 15:47 ` [PATCH 2/2] [pr gdb/19447] sim: mips: Add shadow mappings for 32-bit memory address space Faraz Shahbazker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJwcxTmMa8pcXVwp@vapier \
--to=gdb-patches@sourceware.org \
--cc=cfu@wavecomp.com \
--cc=fshahbazker@wavecomp.com \
--cc=macro@orcam.me.uk \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox