Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Faraz Shahbazker <fshahbazker@wavecomp.com>
To: gdb-patches@sourceware.org
Cc: Faraz Shahbazker <fshahbazker@wavecomp.com>
Subject: [PATCH 2/2] [pr gdb/19447] sim: mips: Add shadow mappings for 32-bit memory address space
Date: Wed,  5 May 2021 21:17:19 +0530	[thread overview]
Message-ID: <20210505154719.217542-2-fshahbazker@wavecomp.com> (raw)
In-Reply-To: <20210505154719.217542-1-fshahbazker@wavecomp.com>

32-bit MIPS programs run on the 64-bit simulator model in 64-bit
sign-extended space. The mapping from 64-bit sign-extended addresses to
32-bit addresses was removed by commit
26f8bf63bf36f9062a5cc1afacf71462a4abe0c8, breaking the 64-bit simulator
model. Add shadow mappings from 64-bit sign extended address space to
32-bit address spaces, in lieu of the AddressTranslation function.

2021-05-04  Faraz Shahbazker  <fshahbazker@wavecomp.com>

sim/mips/ChangeLog:
	* interp.c (sim_open): Add shadow mappings from 32-bit
	address space to 64-bit sign-extended address space.
---
 sim/mips/ChangeLog |  5 +++++
 sim/mips/interp.c  | 12 ++++++++++--
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/sim/mips/ChangeLog b/sim/mips/ChangeLog
index 5dd0dc8512f..db88d64852e 100644
--- a/sim/mips/ChangeLog
+++ b/sim/mips/ChangeLog
@@ -1,3 +1,8 @@
+2021-05-04  Faraz Shahbazker  <fshahbazker@wavecomp.com>
+
+	* interp.c (sim_open): Add memory aliases from 64-bit
+	 sign-extended address space to 32-bit address space.
+
 2021-05-04  Faraz Shahbazker  <fshahbazker@wavecomp.com>
 
 	* interp.c (sim_create_inferior): Only truncate sign extension
diff --git a/sim/mips/interp.c b/sim/mips/interp.c
index fc3a953f3b9..e190a00ff38 100644
--- a/sim/mips/interp.c
+++ b/sim/mips/interp.c
@@ -438,6 +438,9 @@ sim_open (SIM_OPEN_KIND kind, host_callback *cb,
 	  /* memory alias K1BASE@1,K1SIZE%MEMSIZE,K0BASE */
 	  sim_do_commandf (sd, "memory alias 0x%lx@1,0x%lx%%0x%lx,0x%0x",
 			   K1BASE, K1SIZE, (long)mem_size, K0BASE);
+	  if (WITH_TARGET_WORD_BITSIZE == 64)
+	    sim_do_commandf (sd, "memory alias 0x%lx,0x%lx,0x%lx",
+			     (K0BASE), (long)mem_size, EXTENDED(K0BASE));
 	}
 
       device_init(sd);
@@ -699,8 +702,13 @@ sim_open (SIM_OPEN_KIND kind, host_callback *cb,
       unsigned idt_monitor_size = 1 << 11;
 
       /* the default monitor region */
-      sim_do_commandf (sd, "memory region 0x%x,0x%x",
-		       idt_monitor_base, idt_monitor_size);
+      if (WITH_TARGET_WORD_BITSIZE == 64)
+	sim_do_commandf (sd, "memory alias 0x%lx,0x%lx,0x%lx",
+			 (idt_monitor_base), (long)idt_monitor_size,
+			 EXTENDED (idt_monitor_base));
+      else
+	sim_do_commandf (sd, "memory region 0x%lx,0x%x",
+			 idt_monitor_base, idt_monitor_size);
 
       /* Entry into the IDT monitor is via fixed address vectors, and
 	 not using machine instructions. To avoid clashing with use of
-- 
2.25.1


  reply	other threads:[~2021-05-05 15:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 15:47 [PATCH 1/2] [pr gdb/19447] sim: mips: Only truncate sign extension bits for 32-bit target models Faraz Shahbazker
2021-05-05 15:47 ` Faraz Shahbazker [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-05-05 12:18 Faraz Shahbazker
2021-05-05 12:18 ` [PATCH 2/2] [pr gdb/19447] sim: mips: Add shadow mappings for 32-bit memory address space Faraz Shahbazker
2021-05-04 23:21 [PATCH 1/2] [pr gdb/19447] sim: mips: Only truncate sign extension bits for 32-bit target models Faraz Shahbazker
2021-05-04 23:21 ` [PATCH 2/2] [pr gdb/19447] sim: mips: Add shadow mappings for 32-bit memory address space Faraz Shahbazker
2021-05-12 18:21   ` Mike Frysinger via Gdb-patches
2021-05-17  7:37     ` Faraz Shahbazker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210505154719.217542-2-fshahbazker@wavecomp.com \
    --to=fshahbazker@wavecomp.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox