From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mEi/DMscnGBRYwAAWB0awg (envelope-from ) for ; Wed, 12 May 2021 14:22:03 -0400 Received: by simark.ca (Postfix, from userid 112) id 264D41F11C; Wed, 12 May 2021 14:22:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5DC981E783 for ; Wed, 12 May 2021 14:22:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B28CB385801A; Wed, 12 May 2021 18:22:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B28CB385801A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620843721; bh=Y27Q5T3APb9ZdTXikA9+iEwpSzJLpAwFMM+3z297l8U=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Ktjdx7VYiDmyv7ua5CVdBOaNop/aLQFwJvUJXPUpRg+YFPnVO2BluGZxswjRKoiS+ OhYBBwzZnDBC7nMJXcTZHlmWoMSDvPWOyFK4QKrGBpgZ6iodX/XWxlT5hhUGXg7ReW PROb5FIGUFqpkkevPAlAVIMBY7iKWx2gb/msiJj4= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 0F3B7385801A for ; Wed, 12 May 2021 18:21:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0F3B7385801A Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id BD075335C8C; Wed, 12 May 2021 18:21:57 +0000 (UTC) Date: Wed, 12 May 2021 14:21:57 -0400 To: Faraz Shahbazker Subject: Re: [PATCH 2/2] [pr gdb/19447] sim: mips: Add shadow mappings for 32-bit memory address space Message-ID: Mail-Followup-To: Faraz Shahbazker , gdb-patches@sourceware.org, "Maciej W . Rozycki" , Chao-ying Fu References: <20210504232117.896136-1-fshahbazker@wavecomp.com> <20210504232117.896136-2-fshahbazker@wavecomp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210504232117.896136-2-fshahbazker@wavecomp.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Chao-ying Fu , gdb-patches@sourceware.org, "Maciej W . Rozycki" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 05 May 2021 04:51, Faraz Shahbazker wrote: > --- a/sim/mips/interp.c > +++ b/sim/mips/interp.c > @@ -438,6 +438,9 @@ sim_open (SIM_OPEN_KIND kind, host_callback *cb, > /* memory alias K1BASE@1,K1SIZE%MEMSIZE,K0BASE */ > sim_do_commandf (sd, "memory alias 0x%lx@1,0x%lx%%0x%lx,0x%0x", > K1BASE, K1SIZE, (long)mem_size, K0BASE); > + if (WITH_TARGET_WORD_BITSIZE == 64) > + sim_do_commandf (sd, "memory alias 0x%lx,0x%lx,0x%lx", > + (K0BASE), (long)mem_size, EXTENDED(K0BASE)); instead of using %lx & casting to (long), use sim's PRIx* for the format. sim_do_commandf (sd, "memory alias 0x%x,0x%" PRIxTA ",0x%" PRIxTW, K0BASE, mem_size, EXTENDED(K0BASE)); -mike