From: Catalin-Dan Udma <catalin-dan.udma@nxp.com>
To: Pedro Alves <palves@redhat.com>,
Catalin Udma <catalin.udma@freescale.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH] python: Use console format for output of gdb.execute command
Date: Thu, 31 Mar 2016 10:43:00 -0000 [thread overview]
Message-ID: <VI1PR0401MB17763B87A5851F70296DFB0BDA990@VI1PR0401MB1776.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <56FAAFD6.8030705@redhat.com>
Hi,
I'll fix the comments in patch v2.
Please see my comments inline.
Thank you,
Catalin
> > }
> >
> > + /* Restore the saved uiout. */
> > + current_uiout = saved_uiout;
>
> This needs to be restored with a cleanup instead.
[Udma Catalin-Dan] I did not find a cleanup used for struct ui_out. For this purpose
I'll add a new cleanup handler for it in gdb/utils.c and may be re-used in other locations.
prev parent reply other threads:[~2016-03-31 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 14:35 Catalin Udma
2016-03-02 22:20 ` Phil Muldoon
2016-03-03 10:25 ` Catalin-Dan Udma
2016-03-29 16:40 ` Pedro Alves
2016-03-31 10:43 ` Catalin-Dan Udma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0401MB17763B87A5851F70296DFB0BDA990@VI1PR0401MB1776.eurprd04.prod.outlook.com \
--to=catalin-dan.udma@nxp.com \
--cc=catalin.udma@freescale.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox