From: Phil Muldoon <pmuldoon@redhat.com>
To: Catalin Udma <catalin.udma@freescale.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] python: Use console format for output of gdb.execute command
Date: Wed, 02 Mar 2016 22:20:00 -0000 [thread overview]
Message-ID: <56D76731.7060202@redhat.com> (raw)
In-Reply-To: <1456756452-15880-1-git-send-email-catalin.udma@freescale.com>
On 29/02/16 14:34, Catalin Udma wrote:
> When gdb is started in MI mode, the output of gdb.execute
> command is in MI-format in case when it is executed from python stop
> handler while for all other cases the output is in console-format.
>
> To assure consistent output format, this is fixed by using the console
> format for all python gdb command executions.
>
> PR python/19743
While I have no problems with the patch, is the expectation that if
the interpreter is in MI mode and a command has previously output that
structured output, isn't the inverse the bug? Shouldn't gdb.execute
honor the interpreter instead of forcing one? I'm not too sure on
this, not being an MI expert, or whether some commands in GDB
arbitrarily output one or the other. I'll dig around when I find some
time and see if I can find anything definitive.
The other thought of course is, if this is right, it arguably
introduces an API regression. So we might have to work with some
compatibility mode for existing scripts.
A tricky bug!
Cheers
Phil
next prev parent reply other threads:[~2016-03-02 22:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 14:35 Catalin Udma
2016-03-02 22:20 ` Phil Muldoon [this message]
2016-03-03 10:25 ` Catalin-Dan Udma
2016-03-29 16:40 ` Pedro Alves
2016-03-31 10:43 ` Catalin-Dan Udma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D76731.7060202@redhat.com \
--to=pmuldoon@redhat.com \
--cc=catalin.udma@freescale.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox