From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66733 invoked by alias); 31 Mar 2016 10:43:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66706 invoked by uid 89); 31 Mar 2016 10:43:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:15.1.447, H*r:ip*15.1.447.15, H*M:eurprd04 X-HELO: emea01-db3-obe.outbound.protection.outlook.com Received: from mail-db3on0090.outbound.protection.outlook.com (HELO emea01-db3-obe.outbound.protection.outlook.com) (157.55.234.90) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Thu, 31 Mar 2016 10:43:02 +0000 Received: from VI1PR0401MB1776.eurprd04.prod.outlook.com (10.165.234.150) by VI1PR0401MB1773.eurprd04.prod.outlook.com (10.165.234.147) with Microsoft SMTP Server (TLS) id 15.1.447.15; Thu, 31 Mar 2016 10:42:58 +0000 Received: from VI1PR0401MB1776.eurprd04.prod.outlook.com ([10.165.234.150]) by VI1PR0401MB1776.eurprd04.prod.outlook.com ([10.165.234.150]) with mapi id 15.01.0447.025; Thu, 31 Mar 2016 10:42:58 +0000 From: Catalin-Dan Udma To: Pedro Alves , Catalin Udma , "gdb-patches@sourceware.org" Subject: RE: [PATCH] python: Use console format for output of gdb.execute command Date: Thu, 31 Mar 2016 10:43:00 -0000 Message-ID: References: <1456756452-15880-1-git-send-email-catalin.udma@freescale.com> <56FAAFD6.8030705@redhat.com> In-Reply-To: <56FAAFD6.8030705@redhat.com> authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=nxp.com; x-ms-office365-filtering-correlation-id: e1ee6ba3-9817-4325-8fde-08d3595139b8 x-microsoft-exchange-diagnostics: 1;VI1PR0401MB1773;5:I496UEfLDre7N6tZc6TnTtHJZU97Jr1C3pyN7XEUpTqt4hHgWaKwN30O+Myjjsiu0fmCUS1zHl/JQ006CfBXwRF71q+zZVRYsqU2NG0gzFXNDfihvO5542XhCY0DEPKdyx2n6PFDriqxcyxBH5Bhqw==;24:jIL78ySk6wBnzOCAxGvA39MH75//g321hBGwdpOE00phTwv0uhIgbWJnaI+I6Ur4lcyGRuBhHQWRl7b5YwHxAfVZ+tNz/d0t3cznlKDJHrs= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB1773; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:VI1PR0401MB1773;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB1773; x-forefront-prvs: 0898A6E028 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(1220700001)(10400500002)(102836003)(586003)(6116002)(3846002)(1096002)(122556002)(5004730100002)(5002640100001)(3280700002)(2906002)(87936001)(3660700001)(2501003)(5003600100002)(92566002)(81166005)(106116001)(189998001)(77096005)(66066001)(33656002)(107886002)(76576001)(5001770100001)(54356999)(76176999)(86362001)(74316001)(2950100001)(11100500001)(50986999)(5008740100001)(2900100001)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB1773;H:VI1PR0401MB1776.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2016 10:42:58.2960 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1773 X-SW-Source: 2016-03/txt/msg00586.txt.bz2 Hi, I'll fix the comments in patch v2. Please see my comments inline. Thank you, Catalin > > } > > > > + /* Restore the saved uiout. */ > > + current_uiout =3D saved_uiout; >=20 > This needs to be restored with a cleanup instead. [Udma Catalin-Dan] I did not find a cleanup used for struct ui_out. For th= is purpose I'll add a new cleanup handler for it in gdb/utils.c and may be re-used in = other locations.