RE: [PATCH v4 8/9] Windows gdb: Implement AVX-512 register support

["Joos, Christina" <christina.joos@intel.com>]

Hi Hannes,

Thanks for continuing to work on this. 

> > > Similar to commit 01f9f808e2e86187c95e7cff4aeb014a421a53ce for
> > > Linux,
> >
> > Maybe name the commit title instead of the hash. Not sure what is best
> > practice for this.
> 
> This part was suggested to me in another review, so maybe I should just add
> both commit hash and title.

Showing the commit message is definitely a good idea.
My initial review wasn't specific on how exactly you should reference the commit, sorry for that.
I think this commit is a good example:

https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=6b369b641c0efeee51356f72d7b317a8906bb8f3

I just started looking at this again and have one question upfront:
You explained that you ran the dedicated tests for AVX/AVX-512 etc, but has this series also been regression-tested?

Thanks,
Christina


________________________________________
Intel Deutschland GmbH 

Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany 

Tel: +49 (89) 99143-0 

www.intel.de 

Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman

Chairperson of the Supervisory Board: Sonja Pierer

Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.