Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hannes Domani <ssbssa@yahoo.de>
To: gdb-patches@sourceware.org
Subject: [PATCH v4 9/9] Windows gdbserver: Remove win32_target_ops "num_regs" method
Date: Wed, 30 Sep 2026 17:11:43 +0200	[thread overview]
Message-ID: <20260930151403.774660-9-ssbssa@yahoo.de> (raw)
In-Reply-To: <20260930151403.774660-1-ssbssa@yahoo.de>

It's no longer used since the AVX patch.
---
v4: this patch didn't exist before
---
 gdbserver/win32-aarch64-low.cc | 10 ----------
 gdbserver/win32-i386-low.cc    | 16 ----------------
 gdbserver/win32-low.cc         |  2 --
 gdbserver/win32-low.h          |  3 ---
 4 files changed, 31 deletions(-)

diff --git a/gdbserver/win32-aarch64-low.cc b/gdbserver/win32-aarch64-low.cc
index e94548b6fef..dfcb940f3e3 100644
--- a/gdbserver/win32-aarch64-low.cc
+++ b/gdbserver/win32-aarch64-low.cc
@@ -394,15 +394,6 @@ aarch64_arch_setup ()
   aarch64_tdesc = std::move (tdesc);
 }
 
-/* Implement win32_target_ops "num_regs" method.  */
-
-static int
-aarch64_win32_num_regs ()
-{
-  int num_regs = sizeof (aarch64_mappings) / sizeof (aarch64_mappings[0]);
-  return num_regs;
-}
-
 /* Implement win32_target_ops "get_pc" method.  */
 
 static CORE_ADDR
@@ -438,7 +429,6 @@ aarch64_is_sw_breakpoint (const EXCEPTION_RECORD *er)
 
 struct win32_target_ops the_low_target = {
   aarch64_arch_setup,
-  aarch64_win32_num_regs,
   aarch64_initial_stuff,
   aarch64_get_thread_context,
   aarch64_prepare_to_resume,
diff --git a/gdbserver/win32-i386-low.cc b/gdbserver/win32-i386-low.cc
index 8c62787a31b..e35fcbc3da1 100644
--- a/gdbserver/win32-i386-low.cc
+++ b/gdbserver/win32-i386-low.cc
@@ -668,21 +668,6 @@ i386_arch_setup (void)
 #endif
 }
 
-/* Implement win32_target_ops "num_regs" method.  */
-
-static int
-i386_win32_num_regs (void)
-{
-  int num_regs;
-#ifdef __x86_64__
-  if (!windows_process.wow64_process)
-    num_regs = sizeof (amd64_mappings) / sizeof (amd64_mappings[0]);
-  else
-#endif
-    num_regs = sizeof (i386_mappings) / sizeof (i386_mappings[0]);
-  return num_regs;
-}
-
 /* Implement win32_target_ops "get_pc" method.  */
 
 static CORE_ADDR
@@ -738,7 +723,6 @@ i386_is_sw_breakpoint (const EXCEPTION_RECORD *er)
 
 struct win32_target_ops the_low_target = {
   i386_arch_setup,
-  i386_win32_num_regs,
   i386_initial_stuff,
   i386_get_thread_context,
   i386_prepare_to_resume,
diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc
index 3e80405f651..0d08a7e8915 100644
--- a/gdbserver/win32-low.cc
+++ b/gdbserver/win32-low.cc
@@ -62,8 +62,6 @@ gdbserver_windows_process windows_process;
 
 int using_threads = 1;
 
-#define NUM_REGS (the_low_target.num_regs ())
-
 /* The current debug event from WaitForDebugEvent.  */
 static ptid_t
 debug_event_ptid (DEBUG_EVENT *event)
diff --git a/gdbserver/win32-low.h b/gdbserver/win32-low.h
index dffa13e31f8..af12805dcfd 100644
--- a/gdbserver/win32-low.h
+++ b/gdbserver/win32-low.h
@@ -37,9 +37,6 @@ struct win32_target_ops
   /* Architecture-specific setup.  */
   void (*arch_setup) (void);
 
-  /* The number of target registers.  */
-  int (*num_regs) (void);
-
   /* Perform initializations on startup.  */
   void (*initial_stuff) (process_info *proc);
 
-- 
2.55.0


      parent reply	other threads:[~2026-09-30 15:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260930151403.774660-1-ssbssa.ref@yahoo.de>
2026-09-30 15:11 ` [PATCH v4 1/9] gdb/testsuite: Add Windows replacement for aligned_alloc Hannes Domani
2026-09-30 15:11   ` [PATCH v4 2/9] Windows gdb: Use allocated buffer for CONTEXT Hannes Domani
2026-09-30 15:11   ` [PATCH v4 3/9] Windows gdb: Remove mappings member from windows_per_inferior Hannes Domani
2026-09-30 15:11   ` [PATCH v4 4/9] Windows gdb: Refactor getting pointer to register inside context Hannes Domani
2026-09-30 15:11   ` [PATCH v4 5/9] Windows gdb: Prepare XState functions Hannes Domani
2026-09-30 15:11   ` [PATCH v4 6/9] Windows gdb: Get available XState features Hannes Domani
2026-09-30 15:11   ` [PATCH v4 7/9] Windows gdb: Implement AVX register support Hannes Domani
2026-10-05 14:09     ` Rohr, Stephan
2026-10-09 14:30       ` Hannes Domani
2026-10-14 13:04         ` Joos, Christina
2026-09-30 15:11   ` [PATCH v4 8/9] Windows gdb: Implement AVX-512 " Hannes Domani
2026-10-05 14:08     ` Rohr, Stephan
2026-10-09 14:36       ` Hannes Domani
2026-10-12  7:59         ` Joos, Christina
2026-10-12 18:33           ` Hannes Domani
2026-10-26 12:28             ` Joos, Christina
2026-10-14 13:06         ` Joos, Christina
2026-09-30 15:11   ` Hannes Domani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260930151403.774660-9-ssbssa@yahoo.de \
    --to=ssbssa@yahoo.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox