Re: [PATCH v4 8/9] Windows gdb: Implement AVX-512 register support

[Hannes Domani <ssbssa@yahoo.de>]

 Am Montag, 12. Oktober 2026 um 09:59:47 MESZ hat Joos, Christina <christina.joos@intel.com> Folgendes geschrieben:

> Hi Hannes,
> 
> Thanks for continuing to work on this.
> 
> > > > Similar to commit 01f9f808e2e86187c95e7cff4aeb014a421a53ce for
> > > > Linux,
> > >
> > > Maybe name the commit title instead of the hash. Not sure what is best
> > > practice for this.
> >
> > This part was suggested to me in another review, so maybe I should just add
> > both commit hash and title.
> 
> Showing the commit message is definitely a good idea.
> My initial review wasn't specific on how exactly you should reference the commit, sorry for that.
> I think this commit is a good example:
> 
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=6b369b641c0efeee51356f72d7b317a8906bb8f3
> 
> I just started looking at this again and have one question upfront:
> You explained that you ran the dedicated tests for AVX/AVX-512 etc, but has this series also been regression-tested?

Sadly, the testsuite is very unreliable on windows (even though it improved
a lot recently).

I now let it first run with current master as baseline:

# of expected passes 42520
# of unexpected failures 3334
# of unexpected successes 1
# of expected failures 25
# of known failures 45
# of untested testcases 133
# of unresolved testcases 574
# of unsupported tests 356
# of paths in test names 32
# of duplicate test names 60

Then one time with my AVX changes:

# of expected passes 41663
# of unexpected failures 3686
# of unexpected successes 1
# of expected failures 26
# of known failures 45
# of untested testcases 135
# of unresolved testcases 565
# of unsupported tests 355
# of paths in test names 31
# of duplicate test names 54

And again with my changes, so you see what I mean:

# of expected passes 44348
# of unexpected failures 2894
# of unexpected successes 1
# of expected failures 23
# of known failures 45
# of untested testcases 134
# of unresolved testcases 306
# of unsupported tests 359
# of paths in test names 30
# of duplicate test names 44

I think it's funny that even the duplicate test names are different each time.
This was only for gdb.arch/gdb.base/gdb.cp, most of the others wouldn't work anyways.

I can tell you that I first implemented this AVX stuff almost 2 years ago,
and had no problems using gdb related to it since then.


Hannes