Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@is.elta.co.il>
To: Daniel Berlin <dan@cgsoftware.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Improve completion of locations
Date: Sat, 05 May 2001 23:15:00 -0000	[thread overview]
Message-ID: <Pine.SUN.3.91.1010506091647.4974F-100000@is> (raw)
In-Reply-To: <87vgnfk5z1.fsf@dynamic-addr-83-177.resnet.rochester.edu>

On 5 May 2001, Daniel Berlin wrote:

> >   - When the user types "break foo.c:bar TAB", only symbols defined in
> >     the source file foo.c whose names begin with "bar" will be
> >     considered for completion.  This reduces the number of possible
> >     completions by a large factor in many typical situations (I'd even
> >     dare to say that it makes symbol completion a useful feature
> >     ;-).
> 
> Whoops, you can't do this the way you have it implemented (checking if
> they have a colon)
> You'll interfere with C++ completion, because scopes are delimited by
> double colons as well.
> If you disambiguate first by checking if the stuff before the colon is
> a valid source filename, i have no problem with it.
> 
> You can't just check for double colon, either, since I may have typed
> "foo:", wanting to complete foo::bar

I actually tested this, and it seemed to work, but perhaps I didn't
test enough.  Could you please post a test program where this should
be an issue?  I'm afraid my C++ talents are virtually non-existent.

And thanks for reviewing the patch.


  reply	other threads:[~2001-05-05 23:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-05 10:59 Eli Zaretskii
2001-05-05 11:26 ` Daniel Berlin
2001-05-05 23:15   ` Eli Zaretskii [this message]
2001-05-06  0:10     ` Daniel Berlin
2001-05-06  2:05       ` Eli Zaretskii
2001-05-06  9:38         ` Daniel Berlin
2001-05-06 10:04           ` Eli Zaretskii
2001-05-06  3:19       ` Eli Zaretskii
2001-05-08 13:32 ` Elena Zannoni
2001-05-09  3:46   ` Eli Zaretskii
2001-05-11 21:17     ` Elena Zannoni
2001-05-11 23:03       ` Eli Zaretskii
2001-05-14 13:39         ` Elena Zannoni
2001-05-25  1:39   ` Eli Zaretskii
2001-06-04 23:15 ` Eli Zaretskii
2001-06-05  6:10   ` Fernando Nasser
2001-06-05 10:58     ` Eli Zaretskii
2001-06-10  8:46 ` Fernando Nasser
2001-06-10  9:14   ` Daniel Berlin
2001-06-10  9:43     ` Fernando Nasser
2001-06-11  9:09   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.SUN.3.91.1010506091647.4974F-100000@is \
    --to=eliz@is.elta.co.il \
    --cc=dan@cgsoftware.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox