From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eli Zaretskii To: Daniel Berlin Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Improve completion of locations Date: Sat, 05 May 2001 23:15:00 -0000 Message-id: References: <87vgnfk5z1.fsf@dynamic-addr-83-177.resnet.rochester.edu> X-SW-Source: 2001-05/msg00064.html On 5 May 2001, Daniel Berlin wrote: > > - When the user types "break foo.c:bar TAB", only symbols defined in > > the source file foo.c whose names begin with "bar" will be > > considered for completion. This reduces the number of possible > > completions by a large factor in many typical situations (I'd even > > dare to say that it makes symbol completion a useful feature > > ;-). > > Whoops, you can't do this the way you have it implemented (checking if > they have a colon) > You'll interfere with C++ completion, because scopes are delimited by > double colons as well. > If you disambiguate first by checking if the stuff before the colon is > a valid source filename, i have no problem with it. > > You can't just check for double colon, either, since I may have typed > "foo:", wanting to complete foo::bar I actually tested this, and it seemed to work, but perhaps I didn't test enough. Could you please post a test program where this should be an issue? I'm afraid my C++ talents are virtually non-existent. And thanks for reviewing the patch.