From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Ping Re: Fix ARM stepping over Thumb-mode "bx pc" or "blx pc"
Date: Mon, 20 Aug 2012 11:09:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1208201108370.4976@digraph.polyomino.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.1208131630060.21427@digraph.polyomino.org.uk>
On Mon, 13 Aug 2012, Joseph S. Myers wrote:
> On Sat, 11 Aug 2012, Yao Qi wrote:
>
> > I don't have any preference on clearing either the last one bit in
> > address or the last two bits. Looks like two ways coexist in arm-tdep.c
> > nowadays. As 'pc_val' is set by MAKE_THUMB_ADDR at the beginning, it is
> > better to revert its change by using UNMAKE_THUMB_ADDR (which only
> > clears the last one bit of address).
>
> This version uses UNMAKE_THUMB_ADDR as requested. Tested with no
> regressions with cross to arm-none-linux-gnueabi.
>
> 2012-08-13 Joseph Myers <joseph@codesourcery.com>
>
> * arm-tdep.c (thumb_get_next_pc_raw): Mask off low bits for bx pc
> and blx pc.
>
> testsuite:
> 2012-08-13 Joseph Myers <joseph@codesourcery.com>
>
> * gdb.arch/thumb-bx-pc.S: New file.
> * gdb.arch/thumb-bx-pc.exp: New file.
Ping. This patch
<http://sourceware.org/ml/gdb-patches/2012-08/msg00368.html> is pending
review.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-08-20 11:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 17:06 Joseph S. Myers
2012-08-11 7:45 ` Yao Qi
2012-08-13 16:31 ` Joseph S. Myers
2012-08-20 11:09 ` Joseph S. Myers [this message]
2012-08-22 14:36 ` Ping " Yao Qi
2012-08-23 19:09 ` Tom Tromey
2012-08-22 18:01 ` Pedro Alves
2012-08-22 19:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1208201108370.4976@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox