From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>,
Yao Qi <yao@codesourcery.com>,
gdb-patches@sourceware.org
Subject: Re: Fix ARM stepping over Thumb-mode "bx pc" or "blx pc"
Date: Wed, 22 Aug 2012 19:43:00 -0000 [thread overview]
Message-ID: <87ehmysoga.fsf@fleche.redhat.com> (raw)
In-Reply-To: <50351E62.4080607@redhat.com> (Pedro Alves's message of "Wed, 22 Aug 2012 19:01:06 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>> +if [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} $opts] {
>> + untested ${testfile}.exp
[...]
Pedro> Something like:
Pedro> untested "Failed to compile $srcfile"
Pedro> is sufficient.
prepare_for_testing actually calls untested itself, via
build_executable_from_specs, e.g.:
if { [gdb_compile $objects "${binfile}" executable $options] != "" } {
untested $testname
return -1
}
So, I've taken to just eliminating it in these cases.
It is an unfriendly-ish call there, but that is easy to fix.
Tom
prev parent reply other threads:[~2012-08-22 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 17:06 Joseph S. Myers
2012-08-11 7:45 ` Yao Qi
2012-08-13 16:31 ` Joseph S. Myers
2012-08-20 11:09 ` Ping " Joseph S. Myers
2012-08-22 14:36 ` Yao Qi
2012-08-23 19:09 ` Tom Tromey
2012-08-22 18:01 ` Pedro Alves
2012-08-22 19:43 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehmysoga.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=joseph@codesourcery.com \
--cc=palves@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox