From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94004-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1890 invoked by alias); 22 Aug 2012 19:43:02 -0000
Received: (qmail 1874 invoked by uid 22791); 22 Aug 2012 19:43:01 -0000
X-SWARE-Spam-Status: No, hits=-6.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Aug 2012 19:42:49 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7MJglXw019491	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 22 Aug 2012 15:42:47 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7MJgjAK030466	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 22 Aug 2012 15:42:46 -0400
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>, Yao Qi <yao@codesourcery.com>,        gdb-patches@sourceware.org
Subject: Re: Fix ARM stepping over Thumb-mode "bx pc" or "blx pc"
References: <Pine.LNX.4.64.1208101705020.7722@digraph.polyomino.org.uk>	<50260D91.5070000@codesourcery.com>	<Pine.LNX.4.64.1208131630060.21427@digraph.polyomino.org.uk>	<50351E62.4080607@redhat.com>
Date: Wed, 22 Aug 2012 19:43:00 -0000
In-Reply-To: <50351E62.4080607@redhat.com> (Pedro Alves's message of "Wed, 22	Aug 2012 19:01:06 +0100")
Message-ID: <87ehmysoga.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00633.txt.bz2

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> +if [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} $opts] {
>> +    untested ${testfile}.exp

[...]
Pedro> Something like:
Pedro>   untested "Failed to compile $srcfile"
Pedro> is sufficient.

prepare_for_testing actually calls untested itself, via
build_executable_from_specs, e.g.:

    if  { [gdb_compile $objects "${binfile}" executable $options] != "" } {
        untested $testname
        return -1
    }

So, I've taken to just eliminating it in these cases.

It is an unfriendly-ish call there, but that is easy to fix.

Tom