From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3079 invoked by alias); 20 Aug 2012 11:09:24 -0000 Received: (qmail 3069 invoked by uid 22791); 20 Aug 2012 11:09:23 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_BL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Aug 2012 11:09:09 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1T3Pr3-0004RA-7e from joseph_myers@mentor.com for gdb-patches@sourceware.org; Mon, 20 Aug 2012 04:09:09 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 20 Aug 2012 04:09:09 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Mon, 20 Aug 2012 12:09:06 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1T3Pr0-00026G-0b; Mon, 20 Aug 2012 11:09:06 +0000 Date: Mon, 20 Aug 2012 11:09:00 -0000 From: "Joseph S. Myers" To: Yao Qi CC: Subject: Ping Re: Fix ARM stepping over Thumb-mode "bx pc" or "blx pc" In-Reply-To: Message-ID: References: <50260D91.5070000@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00538.txt.bz2 On Mon, 13 Aug 2012, Joseph S. Myers wrote: > On Sat, 11 Aug 2012, Yao Qi wrote: > > > I don't have any preference on clearing either the last one bit in > > address or the last two bits. Looks like two ways coexist in arm-tdep.c > > nowadays. As 'pc_val' is set by MAKE_THUMB_ADDR at the beginning, it is > > better to revert its change by using UNMAKE_THUMB_ADDR (which only > > clears the last one bit of address). > > This version uses UNMAKE_THUMB_ADDR as requested. Tested with no > regressions with cross to arm-none-linux-gnueabi. > > 2012-08-13 Joseph Myers > > * arm-tdep.c (thumb_get_next_pc_raw): Mask off low bits for bx pc > and blx pc. > > testsuite: > 2012-08-13 Joseph Myers > > * gdb.arch/thumb-bx-pc.S: New file. > * gdb.arch/thumb-bx-pc.exp: New file. Ping. This patch is pending review. -- Joseph S. Myers joseph@codesourcery.com